Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vscode-test & @types/vscode instead of vscode #6655

Merged
merged 7 commits into from
Jul 25, 2019
Merged

Use vscode-test & @types/vscode instead of vscode #6655

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0d424d
Use vscode-test & @types/vscode
DonJayamanne Jul 19, 2019
a3e8e21
Oops
DonJayamanne Jul 19, 2019
e90a69d
Refactor
DonJayamanne Jul 19, 2019
f6bc27e
Fixes
DonJayamanne Jul 19, 2019
79fa5e4
Revert changes
DonJayamanne Jul 19, 2019
8b309c9
Review fixes
DonJayamanne Jul 25, 2019
1b8cc05
Review fixes
DonJayamanne Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"python.jediEnabled": false,
"python.analysis.logLevel": "Trace",
"python.analysis.downloadChannel": "beta",
"python.unitTest.promptToConfigure": false,
"python.testing.promptToConfigure": false,
DonJayamanne marked this conversation as resolved.
Show resolved Hide resolved
"python.linting.enabled": true,
"python.linting.pylintEnabled": false,
"python.linting.flake8Enabled": true,
Expand Down
1 change: 1 addition & 0 deletions news/3 Code Health/6456.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed npm package `vscode`, and added to use `vscode-test` and `@types/vscode` (see [here](https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest) for more info).
Loading