Use vscode-test & @types/vscode instead of vscode #6655

DonJayamanne · 2019-07-19T18:51:49Z

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Appropriate comments and documentation strings in the code
Has sufficient logging.
[n/a] Has telemetry for enhancements.
Unit tests & system/integration tests are added/updated
Test plan is updated as appropriate
package-lock.json has been regenerated by running npm install (if dependencies have changed)
The wiki is updated with any design decisions/details.

src/test/constants.ts

src/test/testRunner.ts

.vscode/settings.json

DonJayamanne added 5 commits July 19, 2019 11:50

Use vscode-test & @types/vscode

e0d424d

Oops

a3e8e21

Refactor

e90a69d

Fixes

f6bc27e

Revert changes

79fa5e4

DonJayamanne marked this pull request as ready for review July 19, 2019 19:43

kimadeline reviewed Jul 23, 2019

View reviewed changes

src/test/constants.ts Outdated Show resolved Hide resolved

src/test/testRunner.ts Outdated Show resolved Hide resolved

kimadeline reviewed Jul 23, 2019

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

DonJayamanne added 2 commits July 25, 2019 09:45

Review fixes

8b309c9

Review fixes

1b8cc05

DonJayamanne requested a review from kimadeline July 25, 2019 16:45

kimadeline approved these changes Jul 25, 2019

View reviewed changes

DonJayamanne merged commit ea4f0c4 into microsoft:master Jul 25, 2019

lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019

DonJayamanne deleted the issue6456 branch September 29, 2019 21:02

Provide feedback