Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated icons and tooltip in test explorer indicating status of test files/suites #4650

Merged
merged 4 commits into from
Mar 8, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Mar 5, 2019

For #4583 #4689

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #4650 into master will decrease coverage by 1%.
The diff coverage is 68%.

@@           Coverage Diff           @@
##           master   #4650    +/-   ##
=======================================
- Coverage      77%     77%   -<1%     
=======================================
  Files         447     447            
  Lines       21345   21377    +32     
  Branches     3493    3506    +13     
=======================================
+ Hits        16346   16369    +23     
- Misses       4995    5004     +9     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <66%> (+1%) ⬆️
#Windows 66% <66%> (+1%) ⬆️
#macOS 66% <66%> (+1%) ⬆️

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the .svg files modified? Are those the ones from @luabud?

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for how we calculate pass count.

src/client/unittests/common/services/testResultsService.ts Outdated Show resolved Hide resolved
src/client/unittests/explorer/testTreeViewItem.ts Outdated Show resolved Hide resolved
src/client/unittests/explorer/testTreeViewItem.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/testResultsService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/testResultsService.ts Outdated Show resolved Hide resolved
@karrtikr
Copy link
Author

karrtikr commented Mar 6, 2019

Are those the ones from @luabud?

Actually No. But we are gonna the change the icons eventually anyways ( those don't match with one described in issues). Should i still revert it?

@karrtikr karrtikr changed the title Updated icons and tooltip in test explorer indicating status of test files/suites WIP - Updated icons and tooltip in test explorer indicating status of test files/suites Mar 6, 2019
@karrtikr karrtikr changed the title WIP - Updated icons and tooltip in test explorer indicating status of test files/suites Updated icons and tooltip in test explorer indicating status of test files/suites Mar 6, 2019
@karrtikr karrtikr dismissed stale reviews from DonJayamanne and ericsnowcurrently March 6, 2019 20:24

addressed

@karrtikr
Copy link
Author

karrtikr commented Mar 6, 2019

@DonJayamanne @ericsnowcurrently
Implemented based on the comment of Dan:

If any test fails, the parent should be failure, otherwise pass if all tests that ran passed, and not run if no tests ran.

@karrtikr karrtikr removed the request for review from ericsnowcurrently March 8, 2019 21:24
@karrtikr karrtikr merged commit 54277f8 into microsoft:master Mar 8, 2019
@karrtikr karrtikr deleted the updateTestexp branch March 8, 2019 23:21
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants