-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated icons and tooltip in test explorer indicating status of test files/suites #4650
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4650 +/- ##
=======================================
- Coverage 77% 77% -<1%
=======================================
Files 447 447
Lines 21345 21377 +32
Branches 3493 3506 +13
=======================================
+ Hits 16346 16369 +23
- Misses 4995 5004 +9
Partials 4 4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the .svg files modified? Are those the ones from @luabud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for how we calculate pass count.
Actually No. But we are gonna the change the icons eventually anyways ( those don't match with one described in issues). Should i still revert it? |
addressed
@DonJayamanne @ericsnowcurrently
|
For #4583 #4689
Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)