Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icons and tooltip in test explorer indicating status of test files/suites #4583

Closed
qubitron opened this issue Feb 27, 2019 · 5 comments
Closed

Update icons and tooltip in test explorer indicating status of test files/suites #4583

qubitron opened this issue Feb 27, 2019 · 5 comments
Assignees
@DonJayamanne @karrtikr
Labels
area-testing feature-request Request for new features or functionality
Milestone
2019, week 11 - M...

Comments

@qubitron
Copy link

qubitron commented Feb 27, 2019 •
edited
Loading

Per spec:
image.png

Hover should optionally show number of pass/fail:
image.png
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 27, 2019
@qubitron qubitron added needs proposal Need to make some design decisions needs PR area-testing and removed triage-needed Needs assignment to the proper sub-team needs proposal Need to make some design decisions labels Feb 27, 2019
@DonJayamanne DonJayamanne added the needs proposal Need to make some design decisions label Feb 27, 2019
@DonJayamanne
Copy link

DonJayamanne commented Feb 27, 2019 •
edited
Loading

  • When tests have not run what's the icon against the file, folder, suite, function?
    • Green check mark for all successful tests
    • If any test fails, then parent fails
    • When status = Idle or Unknown, then display a "Not Run" icon
    • Similarly, tooltips would be a summary of all child nodes
  • What happens when a test is skipped?
    • Display not run icon

@DonJayamanne DonJayamanne changed the title Show icons in test explorer indicating status of test files/suites Update icons and tooltip in test explorer indicating status of test files/suites Feb 27, 2019
@DonJayamanne
Copy link

DonJayamanne commented Feb 27, 2019 •
edited
Loading

File to modify:

  • src/client/unittests/explorer/testTreeViewItem.ts
  • Create new tooltip getter to provide tooltip based on data
  • Existing iconPath getter to provide icon based on data

@qubitron
Copy link
Author

@DonJayamanne we should have a "not run" icon that is the same across all levels, if a test is skipped (how?) then it would be the same as not running it.

@DonJayamanne DonJayamanne added feature-request Request for new features or functionality and removed needs proposal Need to make some design decisions labels Feb 28, 2019
@karrtikr karrtikr mentioned this issue Mar 5, 2019
Merged
9 tasks
@DonJayamanne DonJayamanne self-assigned this Mar 11, 2019
@karrtikr karrtikr mentioned this issue Mar 11, 2019
Merged
@DonJayamanne
Copy link

@karrtikr Please check #4727

DonJayamanne pushed a commit that referenced this issue Mar 13, 2019
@DonJayamanne
Icon should be unknown when no tests are run (#4710)
1cc6f39 
For #4583 #4727 Fixing validation
@DonJayamanne
Copy link

Issues identified during demo:

  • Tooltips for folders and files do not work
    • We display the text nan instead of the number
  • Doesn't work with failed or all passed tests
  • Round the number of seconds to 2 decimal places.

@ghost ghost removed the needs PR label Mar 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@karrtikr karrtikr

Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Milestone
2019, week 11 - March Sprint 6
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @karrtikr @qubitron