-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format on type fixes #1798
Format on type fixes #1798
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 74.1% 74.06% -0.04%
==========================================
Files 282 282
Lines 13089 13127 +38
Branches 2335 2348 +13
==========================================
+ Hits 9700 9723 +23
- Misses 3259 3269 +10
- Partials 130 135 +5
Continue to review full report at Codecov.
|
@@ -10,6 +10,20 @@ import { TextRangeCollection } from '../language/textRangeCollection'; | |||
import { Tokenizer } from '../language/tokenizer'; | |||
import { ITextRangeCollection, IToken, TokenType } from '../language/types'; | |||
|
|||
const keywordsWithSpaceBeforeBrace = [ | |||
'and', 'as', 'assert', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add await
as well (#1786 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A complete list of keywords can be found using https://docs.python.org/3/library/keyword.html#keyword.kwlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is list of those that may have (
after them. Does not have to be complete.
}); | ||
test('Dot operator', () => { | ||
testFormatLine('x.y', 'x.y'); | ||
testFormatLine('5 .y', '5.y'); | ||
//testFormatLine('- 135 .bit_length()', '-135.bit_length()'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason why this test is commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am yet to get to #1784, quite an edge case. The -
part is covered by another test.
Fixes #1793
Fixes #1790
Fixes #1788
Fixes #1782
Fixes #1781
Fixes #1780
Fixes #1763
This pull request: