Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatOnType will change two spaces before comment to one #1763

Closed
MisLink opened this issue May 29, 2018 · 6 comments · Fixed by #1798
Closed

formatOnType will change two spaces before comment to one #1763

MisLink opened this issue May 29, 2018 · 6 comments · Fixed by #1798
Assignees
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@MisLink
Copy link

MisLink commented May 29, 2018

Environment data

  • VS Code version: 1.23.1
  • Extension version (available under the Extensions sidebar): 2018.5.0-rc
  • OS and version: MacOS 10.13.4
  • Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
  • Relevant/affected Python packages and their versions: XXX

Actual behavior

a = 1  # two spaces before hash sign
<enter>
a = 1 # one left

Expected behavior

keep two spaces.

BTW, I notice this feature is being considered for deletion (#1586), is this kind of issues welcome?

Steps to reproduce:

  1. XXX

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

XXX
@brettcannon
Copy link
Member

brettcannon commented May 29, 2018

Yep, this info is still welcome as we're re-evaluating whether to keep or remove the feature so bug reports like this are still useful.

@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug needs PR area-formatting labels May 29, 2018
@brettcannon
Copy link
Member

@MikhailArkhipov
Copy link

@MisLink - yes please. This one is trivial to adjust. Do you have the feature on a regular basis?

@MisLink
Copy link
Author

MisLink commented May 30, 2018

well, use frequency of inline comments is very low for me.

@MikhailArkhipov MikhailArkhipov self-assigned this May 30, 2018
@MikhailArkhipov
Copy link

I meant the feature itself (i.e. format on type) :-)

@MikhailArkhipov MikhailArkhipov added this to the May 2018 milestone May 30, 2018
@MisLink
Copy link
Author

MisLink commented May 30, 2018

oh sorry, I misunderstand your meaning...
I take this feature as my default global setting.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants