Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment to Azure Container Apps with ACA extension #3794

Merged
merged 19 commits into from
Feb 6, 2023

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jan 9, 2023

Closes #3535, plus a bunch of tracking issues in ADO. Functionality E2E depends on microsoft/vscode-azurecontainerapps#212 / microsoft/vscode-azurecontainerapps#209.

/cc @MicroFish91

@bwateratmsft bwateratmsft requested a review from a team as a code owner January 9, 2023 15:51
package.json Outdated Show resolved Hide resolved
karolz-ms
karolz-ms previously approved these changes Jan 11, 2023
src/commands/registries/azure/deployImageToAca.ts Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft marked this pull request as ready for review January 19, 2023 17:03
#3818)

* support registryName instead of loginServer

* update docker.io comment
rpreslar4765
rpreslar4765 previously approved these changes Feb 1, 2023
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need to re-approve this

@bwateratmsft bwateratmsft merged commit eff6906 into main Feb 6, 2023
@bwateratmsft bwateratmsft deleted the bmw/acaDeploy branch February 6, 2023 17:41
@bwateratmsft
Copy link
Collaborator Author

Associated docs PR: microsoft/vscode-docs#6028

@microsoft microsoft locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for deploying to Azure Container Apps
4 participants