Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deploying to Azure Container Apps #3535

Closed
bwateratmsft opened this issue May 26, 2022 · 5 comments · Fixed by #3794
Closed

Support for deploying to Azure Container Apps #3535

bwateratmsft opened this issue May 26, 2022 · 5 comments · Fixed by #3794

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented May 26, 2022

We should add support for deployment to Azure Container Apps. Potentially work with the ACA extension or with shared libraries.

We should also consider having this replace the deployment to ACI.

Depends on microsoft/vscode-azurecontainerapps#209.

@bwateratmsft
Copy link
Collaborator Author

A couple of possible options:

  1. The ACA extension puts a command in our context menu. A disadvantage of this is that if the ACA extension is not installed, discoverability isn't there.
  2. The Docker extension puts a small wrapper command in our context menu. It will install ACA if needed and proceed with calling the "real" command in ACA.
  3. The Docker extension implements its own deployment with some level of code sharing.

Of these I prefer 1 or 2.

@bwateratmsft bwateratmsft added this to the 1.24.0 milestone Jun 1, 2022
@philliphoff
Copy link
Member

philliphoff commented Jun 7, 2022

I like (1) the best, by far, and (3) the least, by far. I see (1) as a convenience for a user that already knows and cares enough about ACA to have first installed that extension. I don't quite buy (2) or (3) as an effective means for ACA discovery.

@bwateratmsft
Copy link
Collaborator Author

A question remaining to be answered: do we want to show the command only if ACA extension is already installed?

@bwateratmsft
Copy link
Collaborator Author

A question remaining to be answered: do we want to show the command only if ACA extension is already installed?

After further discussion we've decided we'll show it even without ACA, and provide an experience for getting it installed.

@bwateratmsft
Copy link
Collaborator Author

Associated docs PR: microsoft/vscode-docs#6028

@bwateratmsft bwateratmsft removed their assignment Feb 6, 2023
@microsoft microsoft locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@philliphoff @bwateratmsft @danegsta and others