Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse terminals when applicable #1888

Closed
wants to merge 7 commits into from
Closed

Reuse terminals when applicable #1888

wants to merge 7 commits into from

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Apr 20, 2020

Fixes #251
Unblocks #1840

@bwateratmsft bwateratmsft requested a review from a team as a code owner April 20, 2020 19:25
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

const terminal = ext.terminalProvider.createTerminal(`Shell: ${node.containerName}`);
terminal.sendText(terminalCommand);
terminal.show();
await executeAsTask(context, terminalCommand, `Shell: ${node.containerName}`, /* addDockerEnv: */ true);
Copy link
Collaborator Author

@bwateratmsft bwateratmsft Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell quoting is causing problems here...e.g. attach shell fails on Windows w/ PowerShell.

@bwateratmsft
Copy link
Collaborator Author

Closing this. There are serious problems with shell quoting that make this extremely difficult.

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: option to reuse terminals
2 participants