When no container to show, provider a link to docker tutorial #1878
Conversation
|
I strongly feel we need to keep the "Successfully connected, but no items found" in all of the views. |
My preference is to not show. If we don't show any error to user, they can expect that nothing is wrong with the setup and that implies the connection is successful. In fact, I prefer to not show 'successfully connected ..." in other views as well, instead show something like "Getting Started with Docker..." Lets see what others think. |
|
I would prefer we don’t show the message either. Could we shorten the message in the other panels to “No items found” ?
From: Ravikumar Palanisamy <[email protected]>
Date: Thursday, April 16, 2020 at 2:38 PM
To: microsoft/vscode-docker <[email protected]>
Cc: Mike Morton <[email protected]>, Review requested <[email protected]>
Subject: Re: [microsoft/vscode-docker] When no container to show, provider a link to docker tutorial (#1878)
I strongly feel we need to keep the "Successfully connected, but no items found" in all of the views.
My preference is to not show. If we don't show any error to user, they can expect that nothing is wrong with the setup and that implies the connection is successful. In fact, I prefer to not show 'successfully connected ..." in other views as well, instead show something like "Getting Started with Docker..." Lets see what others think.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-docker%2Fpull%2F1878%23issuecomment-614910091&data=02%7C01%7CMike.Morton%40microsoft.com%7Cec521df06d5a4bfc635d08d7e24e7c1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637226699029922612&sdata=bzVQAcww4SCAH5XhYPu4e2toS4dWiOpvrlWk5CRYUFw%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHHKNV4X63QOWPALB47U5DRM53E3ANCNFSM4MKEPBRQ&data=02%7C01%7CMike.Morton%40microsoft.com%7Cec521df06d5a4bfc635d08d7e24e7c1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637226699029932606&sdata=aLglNJtGLPFcWM0GYY3j7kNVXi93G4hhYatZ9GF6Edk%3D&reserved=0>.
|
|
Not show anything (except the tutorial link) if there is nothing to show. |
|
@BigMorty and I chatted yesterday and he had an alternative idea that I like way better--do a Help and Feedback tab like what Dapr has. For maximum visibility, we can put it at the top of the explorer. Users can move it or hide it as desired (which is built-in and we don't need to implement). Why do we need to put it here in Containers tab? Our average user is not a first time Docker user, they don't need help starting containers. |
…oft#1878) * Show link to docker tutorial * Conditionally show docker tutorial * Help and Feedback view * cache newContainerUser * use AzExtTreeItem * Fix build issue * go back to vscode package * Use local copy of icons * remove glob package * Added a comment
Fixes: #1845 #1893