Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Improve Docker Compose definitions with databases #509

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented Aug 21, 2020

This PR resolves #504, #505, #506, and #507 to the Docker Compose-based definitions that include a database by:

  1. Adding in a database extension, and if possible (Postgres, MariaDB) pre-configuring it
  2. Adding comments into devcontainer.json and docker-compose.yml about where the database can be found
  3. Adding comments to docker-compose.yml about how to expose the database port
  4. Updating the READMEs with more details on the database defaults

//cc: @bamurtaugh @burkeholland @chrmarti

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together, Chuck!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For Node/Mongo docker compose container, please add line to open port
3 participants