Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

For Node/Mongo docker compose container, please add line to open port #504

Closed
diberry opened this issue Aug 18, 2020 · 2 comments · Fixed by #509
Closed

For Node/Mongo docker compose container, please add line to open port #504

diberry opened this issue Aug 18, 2020 · 2 comments · Fixed by #509
Assignees
@Chuxel
Labels
bug Issue identified by VS Code Team member as probable bug node

Comments

@diberry
Copy link
Contributor

diberry commented Aug 18, 2020

Since this is a web/db compose solution, opening a port to access the web makes sense but I don't see it in the files created in the .devcontainer folder.

I would like to see the port so I can change it in case that is easier than changing the source code to use your port.

@chrmarti fyi
@Chuxel Chuxel transferred this issue from microsoft/vscode-remote-release Aug 19, 2020
@Chuxel Chuxel added bug Issue identified by VS Code Team member as probable bug node labels Aug 19, 2020
@Chuxel Chuxel self-assigned this Aug 19, 2020
@Chuxel
Copy link
Member

Chuxel commented Aug 19, 2020 •
edited
Loading

Good catch. forwardPorts should be there but commented out in devcontianer.json like the main node definition.

Chuxel added a commit that referenced this issue Aug 19, 2020
@Chuxel
Add 'forwardPorts' to devcontainer.json (#504)
1fdbae1
@Chuxel
Copy link
Member

Chuxel commented Aug 19, 2020

Resolved - should go in the next release.

@Chuxel Chuxel closed this as completed Aug 19, 2020
@Chuxel Chuxel mentioned this issue Aug 21, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Chuxel Chuxel

Labels
bug Issue identified by VS Code Team member as probable bug node
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Docker Compose definitions with databases microsoft/vscode-dev-containers
2 participants
@Chuxel @diberry