Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C_Cpp.clang_format_path to be scope machine-overridable #5399

Merged
merged 3 commits into from
May 7, 2020
Merged

Change C_Cpp.clang_format_path to be scope machine-overridable #5399

merged 3 commits into from
May 7, 2020

Conversation

elahehrashedi
Copy link
Contributor

bug fix: #4121

@elahehrashedi elahehrashedi requested a review from sean-mcmanus May 1, 2020 19:41
@sean-mcmanus
Copy link
Contributor

This seems good to me, but you should probably wait for someone else to give a 2nd opinion...but if no one does then you could check it.

@elahehrashedi elahehrashedi requested review from a team and sean-mcmanus May 2, 2020 01:30
@bobbrow bobbrow merged commit 40ac9fd into master May 7, 2020
@bobbrow bobbrow deleted the elrashed/4121 branch May 7, 2020 21:13
@pkropachev
Copy link

Ah, it was so convenient to use one common user's settings.json for several Remote - SSH sessions. 😞

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change C_Cpp.clang_format_path to be scope machine-overridable
4 participants
@elahehrashedi @sean-mcmanus @pkropachev @bobbrow