Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C_Cpp.clang_format_path to be scope machine-overridable #4121

Closed
sean-mcmanus opened this issue Aug 22, 2019 · 2 comments · Fixed by #5399
Closed

Change C_Cpp.clang_format_path to be scope machine-overridable #4121

sean-mcmanus opened this issue Aug 22, 2019 · 2 comments · Fixed by #5399
Assignees
@elahehrashedi
Labels
Feature: Code Formatting Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Visual Studio Code Caused by (or depends on changes from) VS Code
Milestone
0.28.0

Comments

@sean-mcmanus
Copy link
Contributor

See microsoft/vscode#73985 .

It would require increasing our vscode dependency to 1.38 (August 2019 release).
@sean-mcmanus sean-mcmanus added Language Service Feature Request Visual Studio Code Caused by (or depends on changes from) VS Code labels Aug 22, 2019
@sean-mcmanus sean-mcmanus added this to the On Deck milestone Aug 22, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Aug 22, 2019
Closed
@bobbrow bobbrow modified the milestones: On Deck, 1.1.0 Sep 27, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Nov 22, 2019
Open
@bobbrow bobbrow modified the milestones: Post-v1, 0.28.0 Apr 20, 2020
@sean-mcmanus
Copy link
Contributor Author

@elahehrashedi See https://github.com/microsoft/vscode-cpptools/pull/3810/files . The change should be similar, but with a "machine-overridable" value (microsoft/vscode#73985 (comment))

@elahehrashedi elahehrashedi mentioned this issue May 1, 2020
Merged
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label May 7, 2020
@bobbrow bobbrow reopened this May 7, 2020
@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elahehrashedi elahehrashedi

Labels
Feature: Code Formatting Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Visual Studio Code Caused by (or depends on changes from) VS Code
Projects
None yet
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

Change C_Cpp.clang_format_path to be scope machine-overridable microsoft/vscode-cpptools
3 participants
@bobbrow @elahehrashedi @sean-mcmanus