Use system installed clang-format only if newer, or bundled version is not executable #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
requested changes
Feb 14, 2020
|
|
||
| // Invoke the version on the system to compare versions. Use ours if it's more recent. | ||
| try { | ||
| let output: string[] = execSync("\"" + path + "\" --version").toString().split(" "); |
There was a problem hiding this comment.
I think the preferred style is
`"${path}" --version`
unless it's a single string concatenation.
sean-mcmanus
approved these changes
Feb 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a path to clang-format is configured explicitly, we'll use it. Otherwise, we will check for one on the system. If we find one on the system, we will:
- Try to invoke our own, to see if we can successfully do so, and to query its version.
- If we fail to invoke our own, use the one found on the system.
- If we successfully execute our own, try to invoke the one found on the system as well, to compare versions.
- If it fails to execute, use our own.
- If both are executable, use the one with the greater version.
This should address: #4963