Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a minimum-required version check before using system installed clang-format #4963

Closed
anjiawei1991 opened this issue Feb 13, 2020 · 3 comments
Closed

Add a minimum-required version check before using system installed clang-format #4963

anjiawei1991 opened this issue Feb 13, 2020 · 3 comments
Assignees
@Colengms
Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Milestone
0.27.0

Comments

@anjiawei1991
Copy link

my clang-format's version is 3.4.2 and has no option of -fallback-style. but the latest cpptools extension use it. and I can hardly upgrade clang-format based on my enviroment.
@anjiawei1991 anjiawei1991 changed the title added option incompatible with the old version of clang-format added option is incompatible with the old version of clang-format Feb 13, 2020
@Colengms
Copy link
Contributor

Hi @anjiawei1991 . Let's use this issue to track adding a minimum version check before trying to use the installed version of clang-format. In the meanwhile, try setting clang_format_path to the clang-format binary bundled with the extension:

"C_Cpp.clang_format_path": "<path_to_the_CppTools_extension>\\LLVM\\bin\\clang-format.exe"

@Colengms Colengms added bug Feature: Code Formatting Language Service regression A bug that didn't exist in a previous release labels Feb 13, 2020
@Colengms Colengms added this to the 1.0.0 milestone Feb 13, 2020
@Colengms Colengms changed the title added option is incompatible with the old version of clang-format Add a minimum-required version check before using system installed clang-format Feb 13, 2020
@Colengms Colengms self-assigned this Feb 13, 2020
@sean-mcmanus
Copy link
Contributor

Setting the hardcoded "<path_to_the_cpptools>" will break after a new version of the extension gets installed. Should we add a setting or variable that enables using the extension's clang-format or do we think a "minimum version" setting is sufficient?

@Colengms Colengms mentioned this issue Feb 14, 2020
Merged
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 14, 2020
@sean-mcmanus
Copy link
Contributor

Fixed in our latest Insiders release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.27.0-insiders

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
None yet
Milestone
0.27.0
Development

No branches or pull requests
3 participants
@sean-mcmanus @anjiawei1991 @Colengms