Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Buffer() #993

Closed
StephenWeatherford opened this issue Jan 7, 2019 · 7 comments
Closed

Replace usage of Buffer() #993

StephenWeatherford opened this issue Jan 7, 2019 · 7 comments
Assignees
@StephenWeatherford
Labels
P1
Milestone
0.11.0 (timeouts)

Comments

@StephenWeatherford
Copy link
Contributor

(node:8460) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
@StephenWeatherford StephenWeatherford added this to the 0.9.1 milestone Jan 7, 2019
@StephenWeatherford StephenWeatherford self-assigned this Jan 23, 2019
@PrashanthCorp PrashanthCorp mentioned this issue Mar 21, 2019
Merged
PrashanthCorp added a commit that referenced this issue Mar 22, 2019
@PrashanthCorp
replace use of new Buffer(str) with Buffer.from(str). Fixes #993 (#1074)
51b0f7a
@StephenWeatherford
Copy link
Contributor Author

Still getting this

(node:39492) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
warning.js:18

@StephenWeatherford StephenWeatherford modified the milestones: 0.11.0, 0.12.0 May 1, 2019
@PrashanthCorp
Copy link
Contributor

I don't see any other place our codebase uses Buffer. Could this be dependency bubbling up the warning?

@StephenWeatherford
Copy link
Contributor Author

Can you figure out where it's coming from?

@PrashanthCorp
Copy link
Contributor

Do you have a repro? That will help me figure out where it's coming from.

@Sneezry
Copy link
Member

Sneezry commented May 24, 2019

If you find this error when install from vsix, this may be the reason: microsoft/vscode#67534

@PrashanthCorp
Copy link
Contributor

Thanks @Sneezry for the tip! We'll keep track of that bug.

@PrashanthCorp
Copy link
Contributor

The referenced issue is fixed, and we don't have a repro.
Closing this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenWeatherford StephenWeatherford

Labels
P1
Projects
None yet
Milestone
0.11.0 (timeouts)
Development

No branches or pull requests
3 participants
@Sneezry @StephenWeatherford @PrashanthCorp