Buffer() deprecation warning when installing a vsix through the command line #67534

chrmarti · 2019-01-30T10:45:18Z

Issue Type: Bug

VS Code version: Code - Insiders 1.31.0-insider (2c987b2, 2019-01-30T06:17:39.118Z)
OS version: Darwin x64 18.0.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.10GB free)
Process Argv
Screen Reader	no
VM	22%

Extensions (29)

Extension	Author (truncated)	Version
unique-lines	bib	1.0.0
ssh	chr	0.0.4
vscode-eslint	dba	1.8.0
Spot	der	0.4.0
ghlink	dt	1.0.2
remotehub	eam	0.2.0
EditorConfig	Edi	0.12.7
tslint	eg2	1.0.42
git-project-manager	fel	1.7.1
vscode-pull-request-github	Git	0.3.2
rest-client	hum	0.21.1
solidity	Jua	0.0.49
theme-karyfoundation-themes	kar	18.2.1
graphql-for-vscode	kum	1.13.0
vscode-azureappservice	ms-	0.11.0
vscode-azurefunctions	ms-	0.13.1
vscode-cosmosdb	ms-	0.9.1
azure-account	ms-	0.8.0
azurecli	ms-	0.4.2
cpptools	ms-	0.21.0
github-issues-prs	ms-	0.9.1
debugger-for-chrome	msj	4.11.1
vscode-docker	Pet	0.5.1
vscode-versionlens	pfl	0.22.0
vscode-workspacecontains-canary	rob	0.0.2
vscode-open-in-github	sys	1.10.1
ayu	tea	0.17.0
vscodeintellicode	Vis	1.1.2
azure-iot-toolkit	vsc	2.2.0

The text was updated successfully, but these errors were encountered:

bpasero · 2019-01-30T10:46:33Z

This is coming as deprecation from our Electron update. If its unclear where this deprecation is coming from, I can help to print a stack from the place where it happens (this requires Electron 4 though from our exploration builds).

sandy081 · 2019-01-30T10:49:57Z

The stack trace would be helpful to know.

bpasero · 2019-01-30T11:22:19Z

@chrmarti @sandy081 to this:

open command line
export NODE_OPTIONS=--throw-deprecation
use code-exploration

Exploration:

macOS: Download
Linux: Download
Windows: Download

chrmarti · 2019-01-30T14:35:02Z

DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
at showFlaggedDeprecation (buffer.js:160:11)
at new Buffer (buffer.js:175:3)
at fromRandomAccessReader (/Applications/Visual Studio Code - Exploration.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:103:16)
at /Applications/Visual Studio Code - Exploration.app/Contents/Resources/app/node_modules.asar/yauzl/index.js:55:5
at FSReqWrap.oncomplete (fs.js:155:5)

sandy081 · 2019-01-30T14:37:50Z

This is coming from yauzl lib. @bpasero Will this gets fixed upstream?

bpasero · 2019-01-30T14:39:22Z

@sandy081 I suggest you check if there is a newer version of yauzl lib that has this fixed. It should get fixed if a popular node lib wants to support node 10

sandy081 · 2019-02-13T15:39:20Z

@bpasero I do not see this warning when running from sources? How can I repro this on dev?

bpasero · 2019-02-13T15:48:43Z

@sandy081 it should show up, I saw it in devtools at least, but never from the comand line.

tristanbarcelon · 2019-04-12T15:27:48Z

I can confirm that this is still happening for me when using code.cmd on Windows to install latest versions of following extensions: ms-azure-devops.azure-pipelines, ms-vscode.powershell, ms-mssql.mssql, ms-vsts.team, ms-vscode.csharp, ms-vscode.azure-account, peterjausovec.vscode-docker, davidanson.vscode-markdownlint, eamodio.gitlens, qezhu.gitlink, yzhang.markdown-all-in-one.

code.cmd : (node:7192) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), 
or Buffer.from() methods instead.

In case this is needed, here's my environment info:

nodejs 8.9.3
npm 5.5.1
windows server 1607 10.0.14393.2791
vscode system installer 1.33.1

shubh3695 · 2019-04-30T18:14:59Z

I too can confirm the existence of the issue
(node:1592) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
nodejs 10.9.0
npm 6.2.0
vscode system installer 1.33.1

David-Else · 2019-05-01T21:19:45Z

When I install extensions on the command line in Fedora 30:

Found 'ban.spellright' in the marketplace.
Installing...
(node:11254) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'ban.spellright' v3.0.38 was successfully installed!
Found 'bierner.comment-tagged-templates' in the marketplace.
Installing...
(node:11280) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'bierner.comment-tagged-templates' v0.2.1 was successfully installed!
Found 'dbaeumer.vscode-eslint' in the marketplace.
Installing...

kitforbes · 2019-05-21T14:47:08Z

On WIndows 10:

code --version
1.34.0
a622c65b2c713c890fcf4fbf07cf34049d5fe758
x64

'EditorConfig.EditorConfig','hashhar.gitattributes','jirkafajfr.vscode-kitchen','mauve.terraform','ms-python.python','ms-vscode.cpptools','ms-vscode.csharp','Pendrica.chef','vscoss.vscode-ansible','waderyan.gitblame','wholroyd.jinja' |
    % { code --install-extension $_ }
Installing extensions...
Installing extension 'editorconfig.editorconfig' v0.13.0...
(node:18360) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'editorconfig.editorconfig' v0.13.0 was successfully installed.
Installing extensions...
Installing extension 'hashhar.gitattributes' v0.4.1...
(node:1664) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'hashhar.gitattributes' v0.4.1 was successfully installed.
Installing extensions...
Installing extension 'jirkafajfr.vscode-kitchen' v0.5.0...
(node:7060) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'jirkafajfr.vscode-kitchen' v0.5.0 was successfully installed.
Installing extensions...
Installing extension 'mauve.terraform' v1.3.11...
(node:9464) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'mauve.terraform' v1.3.11 was successfully installed.
Installing extensions...
Installing extension 'ms-python.python' v2019.4.12954...
(node:11280) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'ms-python.python' v2019.4.12954 was successfully installed.
Installing extensions...
Installing extension 'ms-vscode.cpptools' v0.23.1...
(node:10328) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'ms-vscode.cpptools' v0.23.1 was successfully installed.
Installing extensions...
Installing extension 'ms-vscode.csharp' v1.19.1...
(node:16184) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'ms-vscode.csharp' v1.19.1 was successfully installed.
Installing extensions...
Installing extension 'pendrica.chef' v0.7.1...
(node:6276) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'pendrica.chef' v0.7.1 was successfully installed.
Installing extensions...
Installing extension 'vscoss.vscode-ansible' v0.5.2...
(node:7520) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'vscoss.vscode-ansible' v0.5.2 was successfully installed.
Installing extensions...
Installing extension 'waderyan.gitblame' v2.7.0...
(node:3320) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'waderyan.gitblame' v2.7.0 was successfully installed.
Installing extensions...
Installing extension 'wholroyd.jinja' v0.0.8...
(node:168) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Extension 'wholroyd.jinja' v0.0.8 was successfully installed.

DanTup · 2019-05-23T10:44:43Z

FWIW I see this showing up inside Code in the developer tools now during normal use, if I installed from a VSIX (through the command palette). That is, the error is occurring during extension usage, not just during installation.

In the packed version of my extension, there is no instance of "Buffer()" in the code, so I don't think it's my code directly triggering it.

chrmarti assigned sandy081 Jan 30, 2019

bpasero added the electron-3.0.x-update label Jan 30, 2019

sandy081 added this to the February 2019 milestone Jan 30, 2019

sandy081 added the extensions Issues concerning extensions label Jan 30, 2019

bpasero mentioned this issue Feb 7, 2019

DeprecationWarning: Buffer() is deprecated due to security and usability issues #68044

Closed

kjeremy mentioned this issue Feb 7, 2019

code --install-extension gives DEP0005 #68159

Closed

bpasero mentioned this issue Feb 18, 2019

DeprecationWarning: Buffer() is deprecated due to security and usability issues #65088

Closed

sandy081 modified the milestones: February 2019, March 2019 Feb 25, 2019

AdmiringWorm mentioned this issue Mar 9, 2019

Error message when installing the extension using Chocolatey chocolatey-community/chocolatey-vscode#155

Closed

sandy081 modified the milestones: March 2019, April 2019 Mar 27, 2019

sandy081 modified the milestones: April 2019, May 2019 Apr 12, 2019

testforstephen mentioned this issue May 10, 2019

DeprecationWarning: Buffer() is deprecated due to security and usability issues microsoft/vscode-java-debug#538

Closed

sbatten mentioned this issue May 20, 2019

DeprecationWarning: Buffer() is deprecated #73923

Closed

Sneezry mentioned this issue May 24, 2019

Replace usage of Buffer() microsoft/vscode-cosmosdb#993

Closed

sandy081 mentioned this issue May 26, 2019

Use newer version of yauzl that fixes deprecation Buffer() warning #74365

Merged

sandy081 closed this as completed in #74365 May 26, 2019

sandy081 mentioned this issue May 28, 2019

(node:15900) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. #74438

Closed

vscodebot bot locked and limited conversation to collaborators Jul 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buffer() deprecation warning when installing a vsix through the command line #67534

Buffer() deprecation warning when installing a vsix through the command line #67534

chrmarti commented Jan 30, 2019

bpasero commented Jan 30, 2019

sandy081 commented Jan 30, 2019

bpasero commented Jan 30, 2019 •

edited

Loading

chrmarti commented Jan 30, 2019

sandy081 commented Jan 30, 2019

bpasero commented Jan 30, 2019

sandy081 commented Feb 13, 2019

bpasero commented Feb 13, 2019

tristanbarcelon commented Apr 12, 2019 •

edited

Loading

shubh3695 commented Apr 30, 2019 •

edited

Loading

David-Else commented May 1, 2019

kitforbes commented May 21, 2019

DanTup commented May 23, 2019

Buffer() deprecation warning when installing a vsix through the command line #67534

Buffer() deprecation warning when installing a vsix through the command line #67534

Comments

chrmarti commented Jan 30, 2019

bpasero commented Jan 30, 2019

sandy081 commented Jan 30, 2019

bpasero commented Jan 30, 2019 • edited Loading

chrmarti commented Jan 30, 2019

sandy081 commented Jan 30, 2019

bpasero commented Jan 30, 2019

sandy081 commented Feb 13, 2019

bpasero commented Feb 13, 2019

tristanbarcelon commented Apr 12, 2019 • edited Loading

shubh3695 commented Apr 30, 2019 • edited Loading

David-Else commented May 1, 2019

kitforbes commented May 21, 2019

DanTup commented May 23, 2019

bpasero commented Jan 30, 2019 •

edited

Loading

tristanbarcelon commented Apr 12, 2019 •

edited

Loading

shubh3695 commented Apr 30, 2019 •

edited

Loading