Change from opn (deprecated) to open #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
suggested changes
Mar 26, 2021
ejizba
reviewed
Mar 26, 2021
bwateratmsft
commented
Mar 26, 2021
bwateratmsft
changed the title
…e-azureextensiondev
bwateratmsft
commented
Mar 29, 2021
ejizba
approved these changes
Mar 29, 2021
Co-authored-by: Eric Jizba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been doing some work to eliminate warnings/errors/etc. throughout our build process; one of them is that
opnis deprecated. We can switch toopenwhich is not.I don't think it's needed anymore since VSCode offers thisvscode.env.openExternalAPI, so this lets us eliminate opn as a dependency entirely. That API probably works better in remote cases anyway.I tested out this change with the "Report Issue" button which seemed to be a good test sample--long URL with lots of query string--and everything worked nicely.