Skip to content

Commit

Permalink
Change from opn (deprecated) to open (#867)
Browse files Browse the repository at this point in the history
  • Loading branch information
bwateratmsft authored Mar 29, 2021
1 parent 2912d29 commit cb30f92
Show file tree
Hide file tree
Showing 3 changed files with 89 additions and 29 deletions.
105 changes: 83 additions & 22 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ui/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vscode-azureextensionui",
"author": "Microsoft Corporation",
"version": "0.40.1",
"version": "0.41.0",
"description": "Common UI tools for developing Azure extensions for VS Code",
"tags": [
"azure",
Expand Down Expand Up @@ -40,7 +40,7 @@
"escape-string-regexp": "^2.0.0",
"fs-extra": "^8.0.0",
"html-to-text": "^5.1.1",
"opn": "^6.0.0",
"open": "^8.0.4",
"semver": "^5.7.1",
"vscode-extension-telemetry": "^0.1.5",
"vscode-nls": "^4.1.1",
Expand All @@ -60,7 +60,7 @@
"tslint": "^5.20.1",
"tslint-microsoft-contrib": "5.0.1",
"typescript": "^3.8.3",
"vscode-azureextensiondev": "^0.8.0",
"vscode-azureextensiondev": "^0.8.1",
"vscode-test": "^1.3.0"
}
}
7 changes: 3 additions & 4 deletions ui/src/utils/openUrl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@
*--------------------------------------------------------------------------------------------*/

// tslint:disable-next-line:no-require-imports
import opn = require("opn");
import open = require("open");

export async function openUrl(url: string): Promise<void> {
// Using this functionality is blocked by https://github.com/Microsoft/vscode/issues/25852:
// Using this functionality is blocked by https://github.com/Microsoft/vscode/issues/85930
// await vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(url));

// tslint:disable-next-line: no-unsafe-any
opn(url);
await open(url);
}

0 comments on commit cb30f92

Please sign in to comment.