Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons for 6 new resource types in JsonOutlineProvider #417

Merged
merged 5 commits into from
Dec 15, 2019

Conversation

nilshedstrom
Copy link
Contributor

Added icons for the following resource types in the JsonOutlineProvider

  • Microsoft.Web/sites
  • config
  • Microsoft.Insights/components
  • Microsoft.KeyVault/vaults
  • Microsoft.KeyVault/vaults/secrets
  • Microsoft.Cdn/profiles

The new icons were downloaded from https://www.microsoft.com/en-us/download/details.aspx?id=41937

@msftclas
Copy link

msftclas commented Dec 13, 2019

CLA assistant check
All CLA requirements met.

@StephenWeatherford
Copy link
Contributor

@nilshedstrom Thanks! They all look great, except for "config", which is difficult to see on default dark theme:
image
and is a different size than the others:
image

Did this icon come from a different place? Thx.

@nilshedstrom
Copy link
Contributor Author

@nilshedstrom Thanks! They all look great, except for "config", which is difficult to see on default dark theme:
image
and is a different size than the others:
image

Did this icon come from a different place? Thx.

There is another settings.svg in Azure Icons which is gray but that one did not work with vscode for some reason (displayed as a single pixel).
I changed the icon to the one for Application Configuration which has mor colour and does not look like the parameters icon.

@nilshedstrom
Copy link
Contributor Author

I do not see how my change caused the test TLE colorization array-access.INVALID.json to fail on the Windows build (but passed on Linux and Mac). It seems like it failed on the 2019-12-03 too.

@nilshedstrom
Copy link
Contributor Author

I added an icon for functions (which should solve issue #421).
Refactored the existing icon tests to one (should be a bit faster).
Added tests for function icons.

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again!

@StephenWeatherford StephenWeatherford merged commit 7aa8a9c into microsoft:master Dec 15, 2019
@StephenWeatherford
Copy link
Contributor

We'll be releasing very soon, hopefully Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants