Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Functions" entry in treeview is missing icons #421

Closed
StephenWeatherford opened this issue Dec 14, 2019 · 7 comments
Closed

"Functions" entry in treeview is missing icons #421

StephenWeatherford opened this issue Dec 14, 2019 · 7 comments

Comments

@StephenWeatherford
Copy link
Contributor

image

@nilshedstrom
Copy link
Contributor

This issue is solved in pr #417
In your screenshot I notice that there is no label for the function (instead of {...}).
Maybe get the label from the namespace for functions?

@StephenWeatherford
Copy link
Contributor Author

Partially fixed by #417

@nilshedstrom
Copy link
Contributor

Which part is not fixed?

@StephenWeatherford
Copy link
Contributor Author

StephenWeatherford commented Dec 16, 2019

image

  • Need icons for namespace, individual functions, parameters, outputs, etc.
  • Need to better populate the tree with understanding of functions (for instance understanding that the {...} object is a namespace and labeling it properly, as Nils points out above)

Example file: https://raw.githubusercontent.com/StephenWeatherford/template-examples/master/udf1.json

@nilshedstrom
Copy link
Contributor

I tried to fix this issue in #427

@StephenWeatherford
Copy link
Contributor Author

Fixed by #427

@StephenWeatherford StephenWeatherford added this to the 0.8.4 milestone Feb 5, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2020
@neilpeterson
Copy link
Contributor

Release went out today with this fix - thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants