-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify licensing for public repo, update version/readme/changelog for 0.7.0 #283
Merged
StephenWeatherford
merged 4 commits into
saw/language-server
from
saw/language-server-license
Sep 11, 2019
Merged
Clarify licensing for public repo, update version/readme/changelog for 0.7.0 #283
StephenWeatherford
merged 4 commits into
saw/language-server
from
saw/language-server-license
Sep 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWeatherford
requested review from
PrashanthCorp,
alex-frankel and
fiveisprime
September 9, 2019 19:08
Ignore the build error, it's an issue in the base repo. |
StephenWeatherford
force-pushed
the
saw/language-server-license
branch
from
September 9, 2019 23:16
2440969
to
4450ded
Compare
StephenWeatherford
changed the title
Clarify licensing for public repo
Clarify licensing for public repo, update version/readme/changelog for 0.7.0
Sep 9, 2019
PrashanthCorp
approved these changes
Sep 10, 2019
StephenWeatherford
force-pushed
the
saw/language-server-license
branch
from
September 10, 2019 20:45
4450ded
to
1ba34b3
Compare
alex-frankel
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had one minor comment, but it is not blocking
StephenWeatherford
added a commit
that referenced
this pull request
Sep 17, 2019
* Use standalone language server * fix * work * suites work * suites work * work * work * Test format range * lint * work * format range suites * cleanup * work * Work on Mac * schema validation tests * fix suites * fixes * fix tree tests * Fix colorization suites * Fix more tests * work on functional tests * fix launch.json * Working on expressions functional tests * Expression suites * Expression suites * lint * Change diagnostics source * Fix lang server path * Fix suites * arrow functions * Simplify output of colorization tests * fix colorization results * orphaned files * Fix #250, strings vs expressions boundary cases * Fix suite * Fix suite * fix suite * Increase timeout again work * fix * Update ui * lint * Fix path check * PR fix * Disable lang server tests for now * Lang conf file must be copied to dist (#276) * Lang conf file must be copied to dist * PR fix * Acquire .dotnet core and search further in file for schema * Fix build, suites * Improve language server error handling (#282) * Always validate file if langid=ARM (#285) * Always validate file if langid=ARM * refactor * Show warnings about --wait-for-debugger and custom lang serve path (#286) * Clarify licensing for public repo, update version/readme/changelog for 0.7.0 (#283) * Remove EULA (handled by LICENSE.md) * Clarify licensing in README.md * Bump version, update changelog/readme * Additional changes * grammar * Acquire language server binaries during build (#289) * Acquire language server binaries during build * Update to get threading fix * PR fix * comment * Fixes * IMprove message * Improve message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.