Does not correctly handle when a string starts with a bracket but does not end with a bracket

[StephenWeatherford]

• fix colorization
• fix validation

See https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-authoring-templates#syntax:

To have a literal string start with a bracket [, but not have it interpreted as an expression, add an extra bracket to start the string with [[.

But it turns out you only need the [[ if your string starts with a bracket and ends with a bracket. I.e.:

"value": "[ChefInSpec]InstalledApplicationLinuxResource1;AttributesYmlContent"

is perfectly valid and is interpreted as a string, since it does not end with a bracket.

[StephenWeatherford]

Example template that shows the rules:

{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "1.0.0.0",
    "outputs": {
        ///////////////////////////////////////////////////////////////////////
        // 1: Starts with [ but doesn't end with ] -> it is an unchanged string
        "output1a": {
            "type": "string",
            "value": "[one]two" // -> string: "[one]two" 
        },
        "output1b": {
            "type": "string",
            "value": "[one]two" // -> string: "[one]two"
        },
        "output1c": {
            "type": "string",
            "value": "[abc]withsuffix" // -> string: "[abc]withsuffix"
        },
        "output1d": {
            "type": "string",
            "value": "[Preview]: Audit VMs with insecure password security settings" // -> string: "[Preview]: Audit VMs with insecure password security settings"
        },
        "output1e": {
            "type": "string",
            "value": "[abc" // -> string: "[abc"
        },
        "output1f": {
            "type": "string",
            "value": "[[one]two" // -> string: "[[one]two"
        },

        ///////////////////////////////////////////////////////////////////////
        // 2: Starts with [[ but doesn't end with ] -> it is an (unchanged) string
        "output2a": {
            "type": "string",
            "value": "[[abc" // -> string: "[[abc"
        },
        "output2b": {
            "type": "string",
            "value": "[[[abc" // -> string:  "[[[abc"
        },

        ///////////////////////////////////////////////////////////////////////
        // 3: Starts with [[ and ends with ] -> replace the first [, it is a string
        "output3a": {
            "type": "string",
            "value": "[[one]" // -> string: "[one]"
        },
        "output3b": {
            "type": "string",
            "value": "[[one]two]" // -> string: "[one]two]"
        },
        "output3c": {
            "type": "string",
            "value": "[[[one]two]" // -> string: "[[one]two]"
        },
        "output3d": {
            "type": "string",
            "value": "[[[abc]" // -> string:  "[[abc]"
        },

        ///////////////////////////////////////////////////////////////////////
        // 4: Starts with [ and ends with ] with no whitespace before or after -> it is an expression
        "output4a": {
            "type": "string",
            "value": "[concat('')]" // -> expression: ""
        },

        ///////////////////////////////////////////////////////////////////////
        // 5: Anything else is a string
        "output5a": {
            "type": "string",
            "value": " [one]" // Starts with whitespace -> string: " [one]"
        },
        "output5b": {
            "type": "string",
            "value": "[one] " // Ends with whitespace -> string: "[one] "
        }
    },
    "resources": []
}

Output:

% ./deploy-rg.sh bugs/250/250a.json
{- Finished ..
  "id": "...,
  "location": null,
  "name": "250a",
  "properties": {
    "correlationId": "...",
    "debugSetting": null,
    "dependencies": [],
    "duration": "PT2.0232502S",
    "error": null,
    "mode": "Incremental",
    "onErrorDeployment": null,
    "outputResources": [],
    "outputs": {
      "output1a": {
        "type": "String",
        "value": "[one]two"
      },
      "output1b": {
        "type": "String",
        "value": "[one]two"
      },
      "output1c": {
        "type": "String",
        "value": "[abc]withsuffix"
      },
      "output1d": {
        "type": "String",
        "value": "[Preview]: Audit VMs with insecure password security settings"
      },
      "output1e": {
        "type": "String",
        "value": "[abc"
      },
      "output1f": {
        "type": "String",
        "value": "[[one]two"
      },
      "output2a": {
        "type": "String",
        "value": "[[abc"
      },
      "output2b": {
        "type": "String",
        "value": "[[[abc"
      },
      "output3a": {
        "type": "String",
        "value": "[one]"
      },
      "output3b": {
        "type": "String",
        "value": "[one]two]"
      },
      "output3c": {
        "type": "String",
        "value": "[[one]two]"
      },
      "output3d": {
        "type": "String",
        "value": "[[abc]"
      },
      "output4a": {
        "type": "String",
        "value": ""
      },
      "output5a": {
        "type": "String",
        "value": " [one]"
      },
      "output5b": {
        "type": "String",
        "value": "[one] "
      }
    },
    "parameters": null,
    "parametersLink": null,
    "providers": [],
    "provisioningState": "Succeeded",
    "templateHash": "14695072742888142074",
    "templateLink": null,
    "timestamp": "2021-04-09T18:35:12.056666+00:00",
    "validatedResources": null
  },
  "resourceGroup": "deleteme",
  "tags": null,
  "type": "Microsoft.Resources/deployments"
}

[StephenWeatherford]

Mistakingly closed

[StephenWeatherford]

Decision:

1. Must fix false positives
2. Experiment to see if we can automatically add closing bracket when you insert the beginning bracket
3. if not Updates required to readme #2, then use "hybrid" approach - internally treat strings starting with bracket as an expression but don't show any errors for them