Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure treeDataProvider exists on created web app item #2546

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Ensure treeDataProvider exists on created web app item #2546

merged 1 commit into from
Jul 19, 2023

Conversation

alexweininger
Copy link
Member

Fixes #2421

The error is caused by the tree data provider not bring present on the created web app item. This throws an error when it is refreshed inside of deploy.

It's undefined when the primary item of the create command is a ResourceGroupsItem, which doesn't (and shouldn't) have the treeDataProvider property.

So this only reproduces when the entry point to create is Right clicking the subscription, or App Service grouping items.

@alexweininger alexweininger requested a review from a team as a code owner July 18, 2023 23:53
@alexweininger alexweininger merged commit 31502ee into main Jul 19, 2023
5 checks passed
@alexweininger alexweininger deleted the alex/azure-weasel branch July 19, 2023 01:03
@microsoft microsoft locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to deploy the project by clicking "Deploy" button from the notification
1 participant
@alexweininger