Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to deploy the project by clicking "Deploy" button from the notification #2421

Closed
v-ruizh opened this issue Mar 15, 2023 · 2 comments · Fixed by microsoft/vscode-azureresourcegroups#664 or #2546
Labels
AT-CTI Created by CTI team bug P1
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Mar 15, 2023

OS: Windows 10
Build Version: 20230314.4

Repro Steps:

  1. Open "nodejs-docs-hello-world" project in VS Code.
  2. Create a Node web app.
  3. Click "Deploy" button from the below notification -> Select the project to deploy.
    image
  4. Check whether succeeds to deploy the project or not.

Expect:
Succeed to deploy the project.

Actual:
Fail to deploy the project with an error.
image

More Info:
This issue does not reproduce if deploying the project from context menu or Command Palette.

@v-xinda
Copy link

v-xinda commented Apr 21, 2023

Verified this issue on the latest main branch build 20230420.1, it still reproduces now.

@v-xinda v-xinda reopened this Apr 21, 2023
@alexweininger
Copy link
Member

The error is caused by the tree data provider not bring present on the created web app item. This throws an error when it is refreshed inside of deploy.

It's undefined when the primary item of the create command is a ResourceGroupsItem, which doesn't (and shouldn't) have the treeDataProvider property.

So this only reproduces when the entry point to create is Right clicking the subscription, or App Service grouping items.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AT-CTI Created by CTI team bug P1
Projects
None yet
3 participants