Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X Window System] add libraries for the x window systems #9966

Closed
wants to merge 571 commits into from

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Feb 7, 2020

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@MVoz
Copy link
Contributor

MVoz commented Mar 23, 2020

-- Installing x64-windows-rel
CMake Error at ports/xorg-macros/portfile.cmake:38 (file):
file RENAME failed to rename

E:/tools/vcpkg/packages/xorg-macros_x64-windows/share/aclocal/

to

E:/tools/vcpkg/packages/xorg-macros_x64-windows/share/xorg/aclocal

because: File exists

Call Stack (most recent call first):
scripts/ports.cmake:90 (include)

set(ENV{ACLOCAL} "aclocal -I "${CURRENT_INSTALLED_DIR}/share/xorg/aclocal/"")

vcpkg_configure_make(
SOURCE_PATH ${SOURCE_PATH}
AUTOCONFIG
#SKIP_CONFIGURE
#NO_DEBUG
#AUTO_HOST
#AUTO_DST
#PRERUN_SHELL "export ACLOCAL="aclocal -I ${CURRENT_INSTALLED_DIR}/share/xorg-macros/aclocal/""

original

packages\xorg-macros_x64-windows\share\xorg-macros\aclocal

why rename it? and then fix it in each port?

@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY JackBoosY marked this pull request as ready for review March 26, 2020 05:38
@JackBoosY
Copy link
Contributor

Oh, sorry! I click the ready for review buttom...
If this PR is ready for review, please ping me.

@JackBoosY JackBoosY added the wip label Mar 26, 2020
@Neumann-A Neumann-A marked this pull request as draft April 9, 2020 17:02
@PhoebeHui PhoebeHui removed their assignment May 12, 2020
@JackBoosY
Copy link
Contributor

Pinging @Neumann-A for response. Is work still being done for this PR?

@Neumann-A
Copy link
Contributor Author

@JackBoosY: This depends on #10402

ports/munit/CONTROL Outdated Show resolved Hide resolved
Neumann-A added 2 commits May 15, 2021 17:08
# Conflicts:
#	ports/libxml2/CONTROL
#	ports/libxml2/portfile.cmake
#	ports/pixman/CONTROL
@JackBoosY
Copy link
Contributor

This PR has been inactive for a long time, please reopen it if there is any progress.

@JackBoosY JackBoosY closed this Sep 10, 2021
@Neumann-A
Copy link
Contributor Author

@JackBoosY This PR just requires a word on how to deal with it on linux systems where x libs are normally provided by the system

@JackBoosY
Copy link
Contributor

Should I reopen this? Should I give you some advice? But first you need to provide the current situation.

@Neumann-A
Copy link
Contributor Author

@JackBoosY

Should I reopen this? Should I give you some advice? But first you need to provide the current situation.

So the problem is as follows:

  • On Linux X is typically provided by the system. Should the port in vcpkg be empty in this case or should we switch it to dynamic linkage in this case? Or should there be a way to deactivate X for the user by setting some variable?
  • A lot of ports depend on X but don't declare that dependency. I will probably not change any other ports to declare that dependency correctly considering the waste amount of ports. This needs to be done by other maintainers on port update.
  • There is probably more to discuss but these are the biggest points which need to be solved first.

@JackBoosY
Copy link
Contributor

On Linux X is typically provided by the system. Should the port in vcpkg be empty in this case or should we switch it to dynamic linkage in this case? Or should there be a way to deactivate X for the user by setting some variable?

All libraries provided only by the system should be set to empty ports, and search and use functions should be provided in them. Such as CUDA.

A lot of ports depend on X but don't declare that dependency. I will probably not change any other ports to declare that dependency correctly considering the waste amount of ports. This needs to be done by other maintainers on port update.

Yes, for those ports that use X libraries, they should explicitly state that they depend on X libraries, and these modifications can be done during the update. You can also temporarily disable these features that depends on X libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port request: mesa software renderer
10 participants