Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][libxdamage,libxext,libxfixes] add ports #26486

Merged
merged 12 commits into from
Aug 26, 2022

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Aug 23, 2022

from #9966 (#21584)

fixes baseline regression in crossbuilds of libx11

github-actions[bot]
github-actions bot previously approved these changes Aug 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libx11 have changed but the version was not updated
version: 1.7.3.1
old SHA: 1347521fb39c2ccfd11521a3e641854537799ca4
new SHA: c806c9de04c179c55f097193cea8929afa773af3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 698ca0211d697b16f81c0040003c19f992d82604 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 82e464d..ad8733c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4270,7 +4270,7 @@
     },
     "libx11": {
       "baseline": "1.7.3.1",
-      "port-version": 0
+      "port-version": 1
     },
     "libxau": {
       "baseline": "1.0.9",
diff --git a/versions/l-/libx11.json b/versions/l-/libx11.json
index fe64a75..b81a98e 100644
--- a/versions/l-/libx11.json
+++ b/versions/l-/libx11.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f0660dadb946f627fc687b3412e9d351ed2887f9",
+      "version": "1.7.3.1",
+      "port-version": 1
+    },
     {
       "git-tree": "1347521fb39c2ccfd11521a3e641854537799ca4",
       "version": "1.7.3.1",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 698ca0211d697b16f81c0040003c19f992d82604 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 82e464d..ad8733c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4270,7 +4270,7 @@
     },
     "libx11": {
       "baseline": "1.7.3.1",
-      "port-version": 0
+      "port-version": 1
     },
     "libxau": {
       "baseline": "1.0.9",
diff --git a/versions/l-/libx11.json b/versions/l-/libx11.json
index fe64a75..061d9a8 100644
--- a/versions/l-/libx11.json
+++ b/versions/l-/libx11.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d7d1aedd8a7e7257476d400addb730b2da9aeddd",
+      "version": "1.7.3.1",
+      "port-version": 1
+    },
     {
       "git-tree": "1347521fb39c2ccfd11521a3e641854537799ca4",
       "version": "1.7.3.1",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 698ca0211d697b16f81c0040003c19f992d82604 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 82e464d..ad8733c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4270,7 +4270,7 @@
     },
     "libx11": {
       "baseline": "1.7.3.1",
-      "port-version": 0
+      "port-version": 1
     },
     "libxau": {
       "baseline": "1.0.9",
diff --git a/versions/l-/libx11.json b/versions/l-/libx11.json
index fe64a75..5a50e3f 100644
--- a/versions/l-/libx11.json
+++ b/versions/l-/libx11.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6ed255634708b79caaffd82d420f576fc4d91aa2",
+      "version": "1.7.3.1",
+      "port-version": 1
+    },
     {
       "git-tree": "1347521fb39c2ccfd11521a3e641854537799ca4",
       "version": "1.7.3.1",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 698ca0211d697b16f81c0040003c19f992d82604 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 82e464d..ad8733c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4270,7 +4270,7 @@
     },
     "libx11": {
       "baseline": "1.7.3.1",
-      "port-version": 0
+      "port-version": 1
     },
     "libxau": {
       "baseline": "1.0.9",
diff --git a/versions/l-/libx11.json b/versions/l-/libx11.json
index fe64a75..2de36f6 100644
--- a/versions/l-/libx11.json
+++ b/versions/l-/libx11.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "7b8cb07d3d809cb73cd601c2e74a562e47413b29",
+      "version": "1.7.3.1",
+      "port-version": 1
+    },
     {
       "git-tree": "1347521fb39c2ccfd11521a3e641854537799ca4",
       "version": "1.7.3.1",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 698ca0211d697b16f81c0040003c19f992d82604 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 82e464d..ad8733c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4270,7 +4270,7 @@
     },
     "libx11": {
       "baseline": "1.7.3.1",
-      "port-version": 0
+      "port-version": 1
     },
     "libxau": {
       "baseline": "1.0.9",
diff --git a/versions/l-/libx11.json b/versions/l-/libx11.json
index fe64a75..9e71dbb 100644
--- a/versions/l-/libx11.json
+++ b/versions/l-/libx11.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "e69bacce69d31cc63b4c1f6c5637ba204289a496",
+      "version": "1.7.3.1",
+      "port-version": 1
+    },
     {
       "git-tree": "1347521fb39c2ccfd11521a3e641854537799ca4",
       "version": "1.7.3.1",

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 24, 2022
ports/libxdamage/vcpkg.json Show resolved Hide resolved
ports/libxext/vcpkg.json Show resolved Hide resolved
@JonLiu1993 JonLiu1993 requested a review from JackBoosY August 24, 2022 09:17
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 24, 2022
@JackBoosY JackBoosY changed the title [libxdamage,libxext,libxfixes] add ports [vcpkg baseline][libxdamage,libxext,libxfixes] add ports Aug 24, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 3163230 into microsoft:master Aug 26, 2022
@Neumann-A Neumann-A deleted the xwindow_part_2 branch August 26, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants