[ace] Added TAO as feature #8468

bold84 · 2019-10-06T14:09:55Z

Added CMake files to find ACE and TAO

msftclas · 2019-10-06T14:10:07Z

All CLA requirements met.

parent 1ebb733d78d592b597e46bc7c5a491e646023ed3 author Benjamin Oldenburg <[email protected]> 1570361425 +0700 committer Benjamin Oldenburg <[email protected]> 1570404986 +0700 Added TAO to ACE port

bold84 · 2019-10-07T16:18:32Z

I won't make any further changes. All builds succeed.

cbezault · 2019-10-07T22:43:51Z

Why are you providing find modules? You should be providing config files if anything.

bold84 · 2019-10-07T22:46:01Z

I wasn't aware of that. I'll have a look at the documentation. I'd appreciate if you gave me a hint though. Curtis J Bezault <[email protected]> schrieb am Di., 8. Okt. 2019, 05:44:

…

Why are you providing find modules? You should be providing config files if anything. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8468?email_source=notifications&email_token=AFBD2MO6N3KKBUFYTJDD7J3QNO3TPA5CNFSM4I54EBP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASBJNY#issuecomment-539235511>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFBD2MNISUYIGKWNNP56ZW3QNO3TPANCNFSM4I54EBPQ> .

MVoz · 2019-10-07T23:19:58Z

hmm... error

\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" завершилась с кодом -1073741515. [E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\tao\tao\TransportCurrent\TC_IIOP_Idl.vcxproj]
  Invoking "E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\bin\tao_idl on ZIOP.pidl"

      <Command Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">setlocal&#x0D;&#x0A;PATH=%PATH%;E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\lib&#x0D;&#x0A;cmd /c &quot;E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\bin\tao_idl -Wb,pre_include=ace/pre.h -Wb,post_include=ace/post.h -IE:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\tao -Wb,versioning_begin=TAO_BEGIN_VERSIONED_NAMESPACE_DECL -Wb,versioning_end=TAO_END_VERSIONED_NAMESPACE_DECL -Wb,export_include=tao/TransportCurrent/Transport_Current_Export.h -Wb,export_macro=TAO_Transport_Current_Export -iC tao/TransportCurrent -I./TransportCurrent -SS -Sci &quot;TC_IIOP.idl&quot;&quot;&#x0D;&#x0A;endlocal</Command>
      <Message Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Invoking "E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\bin\tao_idl on TC_IIOP.idl"</Message>

tag " causes an error or does not find the file TC_IIOP.idl or ace/pre.h or ace/post.h

and such everywhere, where present <CustomBuild

Corrected the installation location for TAO_IDL

bold84 · 2019-10-08T00:25:58Z

hmm... error

I originally started this port with another name a few weeks ago. While merging it to this ACE port, I forgot to change the target directory for the executables (i.e. tao_idl) from ace-tao to ace. That's fixed now.

MVoz · 2019-10-08T02:29:17Z

ports/ace/portfile.cmake

 include(vcpkg_common_functions)

-# Don't change to vcpkg_from_github! This points to a release and not an archive
+set(ACE_ROOT ${CURRENT_BUILDTREES_DIR}/src/ACE_wrappers)


Suggested change

set(ACE_ROOT ${CURRENT_BUILDTREES_DIR}/src/ACE_wrappers)

set(ACE_ROOT ${CURRENT_BUILDTREES_DIR}/src/ACE_wrappers)

ACE_ROOT == $(SourcesDirectory)/ACE
https://github.com/DOCGroup/ACE_TAO/blob/57c52c1183d8d5e11e725fc9886263dfca11f22c/azure-pipelines.yml#L2

? MPC_ROOT
https://github.com/DOCGroup/ACE_TAO/blob/57c52c1183d8d5e11e725fc9886263dfca11f22c/azure-pipelines.yml#L4

default.features == -features

qos=1,rwho=1,sctp=1,xerces3=1,ssl=1,versioned_namespace=1

$(ACE_ROOT)\bin\MakeProjectCreator\config\default.features
https://github.com/DOCGroup/ACE_TAO/blob/57c52c1183d8d5e11e725fc9886263dfca11f22c/azure-pipelines.yml#L73

@voskrese

ACE_ROOT & MPC_ROOT
The folder structure of the ACE_TAO git repository is different from the one in the archive.

default.features
Yes. I will change that. :-)

Has this requirement been resolved?

MVoz · 2019-10-08T02:39:33Z

can immediately add?
CIAO_ROOT, DANCE_ROOT, DDS_ROOT

https://github.com/objectcomputing/OCITAO
http://www.dre.vanderbilt.edu/~schmidt/CIAO.html

https://github.com/rticommunity/rticonnextdds-connector
https://github.com/rticommunity/rticonnextdds-connector-cs

https://github.com/objectcomputing/OpenDDS

;-)
https://github.com/ADLINK-IST/opensplice

http://www.dre.vanderbilt.edu/~schmidt/TAO-integrators.html

http://download.dre.vanderbilt.edu

cbezault · 2019-10-08T03:52:35Z

In general find modules are written by the consumers of cmake libraries. Config files are created by the consumed library for the benefit of the consumers. Both define targets and all other variables necessary to consume a library.

MVoz · 2019-10-08T04:42:29Z

other error

vcpkg install ace[*]:x64-windows

ace[core,qt5,ssl,tao,tao-bzip2,tao-zlib,wchar,xml]:x64-windows

error
?strdup@ACE_OS@@YAPEADPEBD@Z

Точка входа в процедуру ?strdup@ACE_OS@@YAPEADPEBD@Z не найдена в библиотеке DLL E:\tools\vcpkg\buildtrees\ace\src\ACE_wrappers\lib\TAO_IDL_BE.dll.

E:/tools/vcpkg/downloads/tools/perl/perl/bin/perl.exe E:/tools/vcpkg/buildtrees/ace/src/ACE_wrappers/bin/mwc.pl -type vs2017 TAO_ACE.mwc -features stl=1,ace_for_tao=0,ace_inline=0,uses_wchar=1,xml=1,ssl=1,qt5=1,bzip2=1,zlib=0 -workers 5 -use_env -expand_vars

ace[core,qt5,ssl,tao,tao-bzip2,tao-zlib,wchar,xml]

?
,zlib=0,ace_for_tao=0,ace_inline=0
-features stl=1,ace_for_tao=0,ace_inline=0,uses_wchar=1,xml=1,ssl=1,qt5=1,bzip2=1,zlib=0

bold84 · 2019-10-08T07:48:29Z

other error

@voskrese
I can not reproduce it

PS C:\vcpkg> .\vcpkg.exe install ace[*]
The following packages will be built and installed:
ace[core,qt5,ssl,tao,tao-bzip2,tao-zlib,wchar,xml]:x64-windows
Starting package 1/1: ace:x64-windows
Building package ace[core,qt5,ssl,tao,tao-bzip2,tao-zlib,wchar,xml]:x64-windows...
Warning: abi keys are missing values:
bzip2
openssl
qt5-base
zlib

-- Using cached C:/vcpkg/downloads/ACE+TAO-src-6.5.6.tar.gz
-- Extracting source C:/vcpkg/downloads/ACE+TAO-src-6.5.6.tar.gz
-- Applying patch C:/vcpkg/ports/ace/qtcoreapplication.patch
-- Applying patch C:/vcpkg/ports/ace/bzip2.patch
-- Applying patch C:/vcpkg/ports/ace/mpc-arm.patch
-- Applying patch C:/vcpkg/ports/ace/stacktrace-arm.patch
-- Applying patch C:/vcpkg/ports/ace/arm_prevent_amd64_definition.patch
,uses_wchar=1,xml=1,ssl=1,qt5=1,bzip2=1,zlib=1
-- Building C:/vcpkg/buildtrees/ace/src/ACE_wrappers/tao/TAO_ACE.sln for Release

MVoz · 2019-10-08T08:00:49Z

is guilty, means at me remained everything in a cache, files were not reconfigured
will look further

ports/ace/CONTROL

jwillemsen · 2019-10-11T07:58:43Z

ports/ace/bzip2.patch

@@ -0,0 +1,11 @@
+--- a/MPC/config/bzip2.mpb	2019-10-06 11:14:51.164094600 +0700
+++ b/MPC/config/bzip2.mpb	2019-10-06 11:15:08.269289500 +0700
+@@ -5,8 +5,6 @@


Could you create a PR for MPC https://github.com/DOCGroup/MPC

Yes... I've moved our office. I expect to be done tonight and can take care about this and the other PRs on the weekend.

ports/ace/CONTROL

JackBoosY · 2019-11-19T04:14:11Z

/azp run

jwillemsen · 2019-11-20T16:01:01Z

We also have #9016 as another PR in ace

jwillemsen · 2019-11-22T09:17:25Z

See #9074 for the new ACE release which has some of the patches integrated

jwillemsen · 2019-11-28T12:09:56Z

@ordisbold Any plans to finish the TAO feature soon?

JackBoosY · 2019-11-29T05:04:28Z

@ordisbold Ace in vcpkg has been updated to 6.5.7, does your change still work?

bold84 · 2020-04-08T16:28:29Z

I don't understand why it's trying to build qt5-tools on Linux.

.\vcpkg.exe depend-info ace[*]
openssl-windows:
bzip2:
openssl: openssl-windows
xerces-c:
zlib:
ace[wchar, bzip2, xerces-c, ssl, tao, zlib]: bzip2, openssl, xerces-c, zlib

bold84 · 2020-04-08T16:39:47Z

I will focus on the axcioma based build... And I will not try to support all platforms and features immediately. :-D

JackBoosY · 2020-04-09T02:31:52Z

@ordisbold Well, qt5-tools issue has been resolved. Could you reopen this PR again?

bold84 · 2020-04-09T03:15:37Z

@ordisbold Well, qt5-tools issue has been resolved. Could you reopen this PR again?

I don't understand why it even required qt5-tools. I removed everything qt5 and it still failed due to an issue in the qt5 package. 🤔

I reopened it.

But there's a problem regarding this port.

TAO is based on ACE and it is not advisable to separate the build process of these libraries and make TAO a separate port. TAO only supports the decades old IDL-to-C++ mapping, which doesn't support the STL, because the STL wasn't part of the C++ standard when the IDL-to-C++ mapping was defined. The "old" IDL-to-C++ mapping is hard to use and developing with it is error-prone, especially for beginners.

Renedy IT has created a new IDL-to-C++11 mapping. It is now part of the official IDL to language specifications by the OMG.

Remedy IT has also implemened the aforementioned IDL-to-C++11 mapping based on TAO and recently released it with other relevant components (i.e. LwCCM) as open source software. The suite is called AXCIOMA and just the implementation of the new IDL-to-C++11 mapping is called TAOX11.

The question is: how to represent this in vcpkg? The AXCIOMA build process appears to be complex but stable. It implicitly downloads ACE and TAO and builds these libraries with specific settings that the library depends on.

Separating the build processes of ACE, TAO and AXCIOMA Is a can of worms I don't want to open.

JackBoosY · 2020-04-09T03:22:18Z

/azp run

bold84 · 2020-04-09T04:30:51Z

_VCPKG_MAKE_GENERATOR in vcpkg_build_make.cmake seems to be undefined. That's why the Linux build now fails :-D

Where is _VCPKG_MAKE_GENERATOR set?

corrected platform specific library suffixes for libraries needed during runtime of tao_idl temporarily disable Linux builds again :-P

JackBoosY · 2020-04-09T04:57:09Z

@ordisbold _VCPKG_MAKE_GENERATOR is automatically set in vcpkg_configure_make.

ports/ace/portfile.cmake

jwillemsen

Before this PR linux worked as far as I know, now it is disabled, personally I don't like to remove a platform again

JackBoosY

-- Applying patch /home/vcpkg/ports/ace/arm_prevent_amd64_definition.patch
CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:51 (message):
  Applying patch failed.  Checking patch ace/config-win32-common.h...

  error: while searching for:

  #if defined (_WIN64) || defined (WIN64)

  # define ACE_WIN64



  // MPC template adds _AMD64_ but user projects not generated using MPC

  // may want to use _AMD64_ as well.  Ensure it's there in all cases.

  # ifndef _AMD64_

  # define _AMD64_

  # endif



  // Use 64-bit file offsets by default in the WIN64 case, similar to

  // what 64-bit UNIX systems do.

  //



  error: patch failed: ace/config-win32-common.h:39

  error: ace/config-win32-common.h: patch does not apply

Call Stack (most recent call first):
  ports/ace/portfile.cmake:42 (vcpkg_apply_patches)
  scripts/ports.cmake:90 (include)

bold84 · 2020-04-10T04:12:49Z

I won't invest more time into this PR.

I wanted to share the addition of TAO which I have been using here for a while and I didn't expect that the PR consumes more time than the addition of TAO to the port.

So, I don't require it to be merged.

jwillemsen · 2020-04-10T08:00:28Z

Regret to see this closed, would be nice to have tao on vcpkg

ace-tao 6.5.6

7747805

parent 1ebb733d78d592b597e46bc7c5a491e646023ed3 author Benjamin Oldenburg <[email protected]> 1570361425 +0700 committer Benjamin Oldenburg <[email protected]> 1570404986 +0700 Added TAO to ACE port

jwillemsen mentioned this pull request Oct 7, 2019

[New Port Request] ace+tao #8447

Closed

bold84 added 2 commits October 7, 2019 21:38

Enabled building for ARM, ARM64, UWP, Darwin

7f80da2

fix CMake script

0f884f0

Merge branch 'master' into vcpkg-ace-port

0322188

cbezault assigned dan-shaw Oct 7, 2019

Now not copying the CMake Find files anymore.

7676509

Corrected the installation location for TAO_IDL

MVoz reviewed Oct 8, 2019

View reviewed changes

jwillemsen reviewed Oct 11, 2019

View reviewed changes

ports/ace/CONTROL Outdated Show resolved Hide resolved

jwillemsen reviewed Oct 11, 2019

View reviewed changes

jwillemsen reviewed Oct 19, 2019

View reviewed changes

ports/ace/CONTROL Outdated Show resolved Hide resolved

jwillemsen mentioned this pull request Nov 18, 2019

Problems building with Qt OpenDDS/OpenDDS#1377

Closed

jwillemsen mentioned this pull request Nov 22, 2019

[ace] Attempt to add MacOSX support #9077

Closed

JackBoosY changed the title ~~Added TAO as feature~~ [ace] Added TAO as feature Nov 29, 2019

bold84 added 3 commits April 8, 2020 23:01

Removed Qt5 support

4337dec

Don't support UWP

6a99966

Don't support linux and expect such build to fail

e74ce5a

bold84 closed this Apr 8, 2020

bold84 deleted the vcpkg-ace-port branch April 8, 2020 16:40

bold84 restored the vcpkg-ace-port branch April 9, 2020 02:47

bold84 reopened this Apr 9, 2020

bold84 added 4 commits April 9, 2020 10:46

x86 -> Win32

5bbcdbe

"re-enable" linux build

ada4b76

working dir for linux build

78e8c7b

removed nonsense argument.

29d0cbb

bold84 added 2 commits April 9, 2020 11:36

added vcpkg_configure_make

67212c2

handle executable file extensions correctly

7d38421

corrected platform specific library suffixes for libraries needed during runtime of tao_idl temporarily disable Linux builds again :-P

JackBoosY suggested changes Apr 9, 2020

View reviewed changes

ports/ace/portfile.cmake Outdated Show resolved Hide resolved

bold84 requested a review from JackBoosY April 9, 2020 09:42

jwillemsen suggested changes Apr 9, 2020

View reviewed changes

JackBoosY suggested changes Apr 10, 2020

View reviewed changes

Removed arm_prevent_amd64_definition.patch

e3a74b9

bold84 closed this Apr 10, 2020

jwillemsen mentioned this pull request May 20, 2020

[ace] Simplified port file #11464

Merged

victorburckel mentioned this pull request May 20, 2020

[ace] tao as feature #11473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ace] Added TAO as feature #8468

[ace] Added TAO as feature #8468

bold84 commented Oct 6, 2019

msftclas commented Oct 6, 2019 •

edited

Loading

bold84 commented Oct 7, 2019

cbezault commented Oct 7, 2019

bold84 commented Oct 7, 2019 via email

MVoz commented Oct 7, 2019

bold84 commented Oct 8, 2019

MVoz Oct 8, 2019 •

edited

Loading

bold84 Oct 8, 2019

JackBoosY Apr 3, 2020

MVoz commented Oct 8, 2019 •

edited

Loading

cbezault commented Oct 8, 2019

MVoz commented Oct 8, 2019 •

edited

Loading

bold84 commented Oct 8, 2019 •

edited

Loading

MVoz commented Oct 8, 2019

jwillemsen Oct 11, 2019

bold84 Oct 11, 2019

JackBoosY commented Nov 19, 2019

jwillemsen commented Nov 20, 2019

jwillemsen commented Nov 22, 2019

jwillemsen commented Nov 28, 2019

JackBoosY commented Nov 29, 2019

bold84 commented Apr 8, 2020

bold84 commented Apr 8, 2020

JackBoosY commented Apr 9, 2020

bold84 commented Apr 9, 2020 •

edited

Loading

JackBoosY commented Apr 9, 2020

bold84 commented Apr 9, 2020

JackBoosY commented Apr 9, 2020

jwillemsen left a comment

JackBoosY left a comment

bold84 commented Apr 10, 2020 •

edited

Loading

jwillemsen commented Apr 10, 2020

	set(ACE_ROOT ${CURRENT_BUILDTREES_DIR}/src/ACE_wrappers)
	set(ACE_ROOT ${CURRENT_BUILDTREES_DIR}/src/ACE_wrappers)

[ace] Added TAO as feature #8468

[ace] Added TAO as feature #8468

Conversation

bold84 commented Oct 6, 2019

msftclas commented Oct 6, 2019 • edited Loading

bold84 commented Oct 7, 2019

cbezault commented Oct 7, 2019

bold84 commented Oct 7, 2019 via email

MVoz commented Oct 7, 2019

bold84 commented Oct 8, 2019

MVoz Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

bold84 Oct 8, 2019

Choose a reason for hiding this comment

JackBoosY Apr 3, 2020

Choose a reason for hiding this comment

MVoz commented Oct 8, 2019 • edited Loading

cbezault commented Oct 8, 2019

MVoz commented Oct 8, 2019 • edited Loading

bold84 commented Oct 8, 2019 • edited Loading

MVoz commented Oct 8, 2019

jwillemsen Oct 11, 2019

Choose a reason for hiding this comment

bold84 Oct 11, 2019

Choose a reason for hiding this comment

JackBoosY commented Nov 19, 2019

jwillemsen commented Nov 20, 2019

jwillemsen commented Nov 22, 2019

jwillemsen commented Nov 28, 2019

JackBoosY commented Nov 29, 2019

bold84 commented Apr 8, 2020

bold84 commented Apr 8, 2020

JackBoosY commented Apr 9, 2020

bold84 commented Apr 9, 2020 • edited Loading

JackBoosY commented Apr 9, 2020

bold84 commented Apr 9, 2020

JackBoosY commented Apr 9, 2020

jwillemsen left a comment

Choose a reason for hiding this comment

JackBoosY left a comment

Choose a reason for hiding this comment

bold84 commented Apr 10, 2020 • edited Loading

jwillemsen commented Apr 10, 2020

msftclas commented Oct 6, 2019 •

edited

Loading

MVoz Oct 8, 2019 •

edited

Loading

MVoz commented Oct 8, 2019 •

edited

Loading

MVoz commented Oct 8, 2019 •

edited

Loading

bold84 commented Oct 8, 2019 •

edited

Loading

bold84 commented Apr 9, 2020 •

edited

Loading

bold84 commented Apr 10, 2020 •

edited

Loading