-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ace] Simplified port file #11464
Merged
Merged
[ace] Simplified port file #11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
* ports/ace/process_manager.patch: Added. * ports/ace/CONTROL: * ports/ace/portfile.cmake:
* ports/ace/portfile.cmake:
…applied patch * scripts/ci.baseline.txt:
* ports/ace/portfile.cmake:
* ports/ace/process_manager.patch:
* ports/ace/portfile.cmake:
* scripts/ci.baseline.txt:
* ports/ace/CONTROL:
…QoS library * ports/ace/portfile.cmake:
…libraries * ports/ace/CONTROL: * ports/ace/portfile.cmake:
See #8468, there it was added for adding tao |
Looks failure is not caused by my changes |
JackBoosY
suggested changes
May 21, 2020
Co-authored-by: Jack·Boos·Yu <[email protected]>
JackBoosY
approved these changes
May 21, 2020
JackBoosY
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
waiting for response
labels
May 21, 2020
Merged
@jwillemsen should this be the second or third PR merged? |
3rd |
strega-nil
added
the
depends:different-pr
This PR or Issue depends on a PR which has been filed
label
May 21, 2020
dan-shaw
approved these changes
May 27, 2020
@jwillemsen Can you resolve the conflict files? |
Conflicts have been resolved |
victorburckel
added a commit
to victorburckel/vcpkg
that referenced
this pull request
May 28, 2020
Thanks! |
dan-shaw
pushed a commit
that referenced
this pull request
Jun 12, 2020
* Add tao as feature for ace * Use vcpkg_install_msbuild instead of vcpkg_build_msbuild * Use lists for directories installation as in #11464 * Update to version 6.5.9-4 * Update version Co-authored-by: Billy Robert O'Neal III <[email protected]>
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
* Add tao as feature for ace * Use vcpkg_install_msbuild instead of vcpkg_build_msbuild * Use lists for directories installation as in microsoft#11464 * Update to version 6.5.9-4 * Update version Co-authored-by: Billy Robert O'Neal III <[email protected]>
penumbra23
pushed a commit
to codespace-dev/vcpkg
that referenced
this pull request
Aug 5, 2020
* Add tao as feature for ace * Use vcpkg_install_msbuild instead of vcpkg_build_msbuild * Use lists for directories installation as in microsoft#11464 * Update to version 6.5.9-4 * Update version Co-authored-by: Billy Robert O'Neal III <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
depends:different-pr
This PR or Issue depends on a PR which has been filed
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Reworked portfile to use an array to simplify the port file and more easily add more directories later