-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongo-cxx-driver] update to 3.9.0 #34994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These patches have different purposes and shall be left independent:
disable-dynamic-when-static.patch
fix-dependencies.patch
fix-include-directory.patch
fix-mingw.patch
I'm fine with merging the pkg-config changes into fix-dependencies.patch. It is dependencies I/O.
The include directory change is a vcpkg legacy which should better be dropped IMO.
Probably broken by #34994 Detected in #35116 where this REGEX is expected to be output from the python script ``` CMake Error at build/cmake/LoadVersion.cmake:9 (string): string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to command. Call Stack (most recent call first): CMakeLists.txt:20 (LoadVersion) ```
Probably broken by microsoft/vcpkg#34994 Detected in microsoft/vcpkg#35116 where this REGEX is expected to be output from the python script ``` CMake Error at build/cmake/LoadVersion.cmake:9 (string): string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to command. Call Stack (most recent call first): CMakeLists.txt:20 (LoadVersion) ```
Fixes #34984
1.Update the version of mongo-cxx-driver to 3.9.0.
2.Update the versions of mongo-cxx-driver's dependencies libbson and mongo-c-driver to 1.25.1.
The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Usage test pass with following triplets: