Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo-c-driver/libbson] update to 1.25.0 #34865

Closed

Conversation

Adela0814
Copy link
Contributor

Fixes #34855
All feature tested pass on the following triplets:

  • x64-windows
  • x64-windows-static
  • x86-windows
    Usage tested pass on x64-windows.
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 2, 2023
Copy link

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest applying commits from this branch to fix the windows_static tasks.

@@ -59,6 +54,10 @@ file(REMOVE_RECURSE
"${CURRENT_PACKAGES_DIR}/share/mongo-c-driver"
)

if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libbson 1.25.0 supports an ENABLE_SHARED option. I suggest applying kevinAlbs@736861d to conditionally disable dynamic libbson.

HEAD_REF master
PATCHES
disable-dynamic-when-static.patch
Copy link

@kevinAlbs kevinAlbs Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At present, there is no option to disable dynamic libmongoc (refer: CDRIVER-4784). I suggest applying kevinAlbs@b20bf0d to add a patch to conditionally disable dynamic libmongoc.

@jimwang118
Copy link
Contributor

Duplicate of #34994. This PR upgrades libbson to 1.25.1.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2023

#34994 was merged.

@Adela0814 Adela0814 closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongo-c-driver update to 1.25.0
5 participants