-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongo-c-driver/libbson] update to 1.25.0 #34865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest applying commits from this branch to fix the windows_static
tasks.
@@ -59,6 +54,10 @@ file(REMOVE_RECURSE | |||
"${CURRENT_PACKAGES_DIR}/share/mongo-c-driver" | |||
) | |||
|
|||
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libbson 1.25.0 supports an ENABLE_SHARED
option. I suggest applying kevinAlbs@736861d to conditionally disable dynamic libbson.
HEAD_REF master | ||
PATCHES | ||
disable-dynamic-when-static.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At present, there is no option to disable dynamic libmongoc (refer: CDRIVER-4784). I suggest applying kevinAlbs@b20bf0d to add a patch to conditionally disable dynamic libmongoc.
Duplicate of #34994. This PR upgrades |
#34994 was merged. |
Fixes #34855
All feature tested pass on the following triplets:
Usage tested pass on
x64-windows
.The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file../vcpkg x-add-version --all
and committing the result.