-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_configure_make] fix case sensitive comparison in PATH system d… #34791
Conversation
@microsoft-github-policy-service agree company="Regnology" |
|
RE: 2: e65af7b / #32750 (comment) This change seems consistent with what @Neumann-A indicated there so it seems OK to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems reasonable to me but I would really like an understanding of why this is expected to affect the linked issue given that the warning printed when the correct index is not found was not printed.
No I just missed that some kind of normalization to either tolower or toupper should be done to avoid dealing with a lot of mixed cased cases. TOUPPER was just used because upper cased paths have been observed before (e.g. SYSTEM) |
Fixes the
icu
build error with the following message on my system:Unable to find system dir in the PATH variable! Appending required msys paths!
Hopefully fixes #34450