Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_configure_make] Fix serious case of WINDOWS yelling at you #32750

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[vcpkg_configure_make] Fix serious case of WINDOWS yelling at you #32750

merged 1 commit into from
Jul 26, 2023

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jul 25, 2023 •
edited
Loading

maybe closes #32711

@Neumann-A
Fix serious case of WINDOWS yelling at you and not including the msys…
6a614db 
… path into the correct location leading to install failures.
BillyONeal
BillyONeal approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOOOOOOOOOOOOO

@Neumann-A Neumann-A mentioned this pull request Jul 25, 2023
Closed
@jimwang118 jimwang118 self-assigned this Jul 26, 2023
@Neumann-A
Copy link
Contributor Author

according to #32711 (comment) we might to consider some other way of normalizing capitalization in PATH stuff

@jimwang118 jimwang118 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 26, 2023
@BillyONeal
Copy link
Member

according to #32711 (comment) we might to consider some other way of normalizing capitalization in PATH stuff

Are you saying you don't want this to be merged now? If so can you draft the PR?

@Neumann-A
Copy link
Contributor Author

Are you saying you don't want this to be merged now? If so can you draft the PR?

@BillyONeal: I am saying I don't mind another approach on solving the same issue. However without seeing the problematic PATH from #32711 I don't know if it solves their problem or if this just solves my problem.

@BillyONeal
Copy link
Member

@BillyONeal: I am saying I don't mind another approach on solving the same issue. However without seeing the problematic PATH from #32711 I don't know if it solves their problem or if this just solves my problem.

OK, then I'm going to go with 'this fixes some problem' and take this

@BillyONeal BillyONeal changed the title Fix serious case of WINDOWS yelling at you [vcpkg_configure_make] Fix serious case of WINDOWS yelling at you Jul 26, 2023
@BillyONeal BillyONeal merged commit e65af7b into microsoft:master Jul 26, 2023
@Neumann-A Neumann-A deleted the uppercase_windows_in_path_adjustment branch July 26, 2023 18:10
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jul 27, 2023
@LilyWangLL LilyWangLL mentioned this pull request Oct 13, 2023
Closed
@BillyONeal BillyONeal mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICU] build failure
3 participants
@Neumann-A @BillyONeal @jimwang118