Avoid recalculating the default msbuild settings. #31325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment) hunspell and mp3lame are left alone because they do other things with the resulting variable.
Docs changes have been migrated in microsoft/vcpkg-docs#21
|
Please make sure if/when this is merged that: remains because Lily did lots of work here. |
LilyWangLL
approved these changes
May 9, 2023
LilyWangLL
added
category:code-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28189, docs changes to migrated to microsoft/vcpkg-docs#21, but these port changes simplifying to the defaults were left behind. @LilyWangLL suggested separating things out to a separate PR.