Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of https://github.com/microsoft/vcpkg/pull/28189 #21

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

ras0219-msft
Copy link
Collaborator

No description provided.

@prmerger-automator
Copy link

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.

It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:

 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}

We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

@opbld30
Copy link

opbld30 commented Dec 15, 2022

Learn Build status updates of commit 75caa9e:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_build_msbuild.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_install_msbuild.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 20% file change.

@opbld33
Copy link

opbld33 commented Dec 15, 2022

Learn Build status updates of commit 75caa9e:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_build_msbuild.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_install_msbuild.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 20% file change.

@ras0219-msft ras0219-msft merged commit 1766bb6 into microsoft:main Dec 30, 2022
@ras0219-msft ras0219-msft deleted the pr-28189 branch December 30, 2022 17:31
LilyWangLL added a commit to BillyONeal/vcpkg that referenced this pull request May 5, 2023
Docs changes have been migrated in microsoft/vcpkg-docs#21
vicroms pushed a commit to microsoft/vcpkg that referenced this pull request May 9, 2023
* Fix the `vcpkg_install_msbuild` docs to reflect handling of x86==Win32.

See:
* #28119 (comment)
* #28076

* Remove overriding-with-the-default discovered in #28119 (comment)

hunspell and mp3lame are left alone because they do other things with the resulting variable.

* Remove nonexistent reference to `MSBUILD_PLATFORM` variable.

* Simplify getting to x86, as discovered in #28119 (comment)

* Version DB

* Whoops patches shouldn't be quoted.

* Delete vcpkg_install_msbuild.md

Docs changes have been migrated in microsoft/vcpkg-docs#21

* Update ocilib.json

* Update ocilib.json

---------

Co-authored-by: Lily Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants