-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add a Homepage URL entry for vcpkg ports #2933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a great idea |
Why would not include |
This would be very useful. Is there an ETA on when this will be merged ? |
Rastaban
added a commit
to Rastaban/vcpkg
that referenced
this pull request
Jun 10, 2019
This allows a 'Homepage' tag to be added to a port in order to support changes such as PR microsoft#2933. It currently does not do anything with it.
ras0219-msft
pushed a commit
that referenced
this pull request
Jun 10, 2019
* [control file] Add optional 'Homepage' tag This allows a 'Homepage' tag to be added to a port in order to support changes such as PR #2933. It currently does not do anything with it. * [docs] Add Homepage to the control file documentation * move urls from descriptions to homepage field.
/azp run |
The only failure is shogun:x64-linux and looks like it is unrelated to this PR. It should probably not hold up this PR. Update: on rerun the port passed, it is probably just a flaky port. |
@Rastaban add in templates ?
|
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [control file] Add optional 'Homepage' tag This allows a 'Homepage' tag to be added to a port in order to support changes such as PR microsoft#2933. It currently does not do anything with it. * [docs] Add Homepage to the control file documentation * move urls from descriptions to homepage field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1642.
When browsing new ports, it is often hard to understand their purpose. Or where they come from (without looking into
portfile.cmake
). Some examples: http-parser, ode, and lots of others.The idea was to add a human readable URL in port's description, thus
vcpkg
could print it invcpkg list
andvcpkg search
results. However I am not sure about the best place for URL at the moment, so it is an open question.This PR does not implement corresponding changes in vcpkg source (to support the new field), it just adds a
Homepage
entry to almost all ports (except empty ones like winsock2 or atlmfc and except modularized subports likeqt5-
orboost-
). URLs are extracted fromvcpkg_from_github
,vcpkg_from_bitbucket
,vcpkg_download_distfile
so they can be not perfect, but it is the best I can do :)Unresolved questions:
Homepage
?URL
?Repository
? Actually, most of repositories use multiple entries (homepage
andrepository
in Rust crates, homepage, download and issue tracker URLs in pypi and so on).cargo-show
(pip show
,npm view
, etc.) which will print all information about particular port?