Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg install fails to parse CONTROL files (need vcpkg version bumb) #6946

Closed
Farwaykorse opened this issue Jun 18, 2019 · 2 comments · Fixed by #6987
Closed

vcpkg install fails to parse CONTROL files (need vcpkg version bumb) #6946

Farwaykorse opened this issue Jun 18, 2019 · 2 comments · Fixed by #6987
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Farwaykorse
Copy link
Contributor

Farwaykorse commented Jun 18, 2019

Problem

On systems running an older build of vcpkg vcpkg install throws warnings for any port control file containing the new 'Homepage` field (#2933) and fails to build those:

vcpkg install ms-gsl:%PLATFORM%-windows
Warning: an error occurred while parsing 'alembic'
...
Warning: an error occurred while parsing 'ms-gsl'
...
Error: Cannot find definition for package `ms-gsl`.

Both on Windows and Linux builds:
TravisCI - Linux
Appveyor - Windows

The problem is that vcpkg v2018.11.23 as build in November 2018 is not compatible with the updated format for the control files used with vcpkg v2018.11.23 build in June 2019.
Without a version bump there is no warning, users have to figure for themselves out that a rebuild is necessary.
As also noted with one of the PR's: #6844 (comment)

Workaround

Rebuild vcpkg: ./bootstrap-vcpkg.bat
Or for CI systems (travis) remove the cache.

Solution

Vcpkg needs a version increase.
To warn users and to get CI systems, that contain an older build (Appveyor) or cache vcpkg, to rebuild vcpkg.

@Farwaykorse Farwaykorse changed the title vcpkg install fails to parse CONTROL files vcpkg install fails to parse CONTROL files (need vcpkg version bumb) Jun 18, 2019
Farwaykorse added a commit to Farwaykorse/fwkSudoku that referenced this issue Jun 18, 2019
@vicroms vicroms added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jun 18, 2019
@Farwaykorse
Copy link
Contributor Author

@vicroms Why would you label this as a feature?
The current version is 2018.11.23 and the associated update behaviour* has always been a part of vcpkg.
* When the version is changed users receive a warning message with instructions to rebuild vcpkg.

It used to be that @alexkaratarakis regularly updated the version number and changelog.
Solving the issue by creating a PR for toolsrc/VERSION.txt is easy, but updating CHANGELOG.md with all the changes in the past 7 months ...

@ras0219-msft ras0219-msft added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Jun 22, 2019
@ras0219-msft
Copy link
Contributor

Thanks for pointing out this issue!

We do recommend that users always re-run ./bootstrap whenever they change the vcpkg commit. However, for certain changes that we know will cause problems, we do have the warning mechanism that you've mentioned. In this case, we should definitely be using that warning mechanism!

We are currently considering alternative approaches to the CHANGELOG.md file than directly tying it to the version in toolsrc/VERSION.txt; due to that, we would be more than happy to accept a PR just bumping the VERSION.txt :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants