-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ChakraCore] Add Linux support #18476
Conversation
@Pospelove, could you apply the following patch to fix the vcpkg.json file? |
@Pospelove, thanks for your PR! x64-linux in CI pipeline failed with following error, it looks clang is required to build chakracore on linux, if it could be replaced with depending on llvm?
|
@PhoebeHui It seems that ChakraCore requires clang on Linux
|
Co-authored-by: Phoebe <[email protected]>
@Pospelove, could you update the baseline version via './vcpkg x-add-version --overwrite-version chakracore"? |
Co-authored-by: Phoebe <[email protected]>
Co-authored-by: Phoebe <[email protected]>
Co-authored-by: Phoebe <[email protected]>
Co-authored-by: Phoebe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR breaks Windows build. |
It works |
Describe the pull request
What does your PR fix?
Fixes [chakracore] build failure (Linux) #15408
Which triplets are supported/not supported? Have you updated the CI baseline?
Linux, Windows
Does your PR follow the maintainer guide?
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/