Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binary caching] Failed to push some of the ports to NuGet on Ubuntu #19038

Closed
Pospelove opened this issue Jul 21, 2021 · 17 comments
Closed

[binary caching] Failed to push some of the ports to NuGet on Ubuntu #19038

Pospelove opened this issue Jul 21, 2021 · 17 comments
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Pospelove
Copy link
Contributor

Pospelove commented Jul 21, 2021

UPDATE: Easy way to reproduce is here https://github.com/Pospelove/vcpkg-nuget-issue

Describe the bug
Failed to push some of the ports to NuGet after building (binary caching).

Failed ports:

Pushing boost-regex_x64-linux.1.75.0-vcpkg2150fdca76f992a7b944e55522732509d47ede13.nupkg to 'https://nuget.pkg.github.com/skyrim-multiplayer'...
  PUT https://nuget.pkg.github.com/skyrim-multiplayer/
An error was encountered when fetching 'PUT https://nuget.pkg.github.com/skyrim-multiplayer/'. The request will now be retried.
Error while copying content to a stream.
  Unable to read data from the transport connection: The socket has been shut down.
  The socket has been shut down
  PUT https://nuget.pkg.github.com/skyrim-multiplayer/
An error was encountered when fetching 'PUT https://nuget.pkg.github.com/skyrim-multiplayer/'. The request will now be retried.
Error while copying content to a stream.
  Unable to read data from the transport connection: The socket has been shut down.
  The socket has been shut down
  PUT https://nuget.pkg.github.com/skyrim-multiplayer/
An error occurred while sending the request.
  The server returned an invalid or unrecognized response.
Pushing NuGet to GitHub failed. Use --debug for more information.

Environment

  • OS: Ubuntu latest (GitHub Actions)
  • Compiler: Clang 11
  • vcpkg 3c82e19

To Reproduce
Trigger .github/workflows/cmake.yml for skyrim-multiplayer/skymp#85 (last commit hash - 58812850911e8e1488b73be033a0a5d61a7bf551)

Expected behavior
Everything should be pushed to NuGet successfully.

Failure logs
https://github.com/skyrim-multiplayer/skymp/runs/3121332869?check_suite_focus=true

See also
NuGet/Home#8580

@Neumann-A
Copy link
Contributor

Do you have more than one NuGet binary cache for vcpkg on Github?

@Pospelove
Copy link
Contributor Author

Do you have more than one NuGet binary cache for vcpkg on Github?

No.

@JackBoosY
Copy link
Contributor

Maybe related to #15289.

@JackBoosY JackBoosY added the requires:repro The issue is not currently repro-able label Jul 22, 2021
@Pospelove
Copy link
Contributor Author

Pospelove commented Jul 22, 2021

Maybe related to #15289.

@JackBoosY I can create a sample repo with a minimal reproducible example if it helps.

@JackBoosY
Copy link
Contributor

@Pospelove Yes please.

@JackBoosY JackBoosY added the requires:more-information This Issue requires more information to solve label Jul 22, 2021
@Hoikas
Copy link
Contributor

Hoikas commented Jul 23, 2021

This is the same issue I mentioned to @ras0219-msft in discord a few months ago. I saw it with the physx and python3 ports on macOS and Linux.

@Pospelove Pospelove changed the title Failed to push some of the ports to NuGet after building (binary caching). [binary caching] Failed to push some of the ports to NuGet on Ubuntu Jul 24, 2021
@Pospelove
Copy link
Contributor Author

Pospelove commented Jul 24, 2021

@JackBoosY

It's finally out:
https://github.com/Pospelove/vcpkg-nuget-issue

This is a very minimal repo. The only things it contains are vcpkg submodule, manifest, and a workflow file.
See readme.

It's based on GitHub Actions because of the original example. Please let me know if you need to reproduce this bug locally instead of using GitHub Actions.

@m-kuhn
Copy link
Contributor

m-kuhn commented Jul 27, 2021

gdal is also affected

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed requires:more-information This Issue requires more information to solve requires:repro The issue is not currently repro-able labels Jul 27, 2021
@m-kuhn
Copy link
Contributor

m-kuhn commented Jul 28, 2021

gdal is also affected

This seems to be a different issue #19189

@PhoebeHui
Copy link
Contributor

Related to NuGet/Home#8580 and NuGet/Home#10045.

It seems nuget issue on ubuntu, I'm not sure what should vcpkg do here, update the docs? @ras0219-msft @ras0219, could you please take a look?

@Pospelove
Copy link
Contributor Author

Any progress on this?

@Pospelove
Copy link
Contributor Author

image
image
image

@JackBoosY
Copy link
Contributor

@BillyONeal Any ideas?

@BillyONeal
Copy link
Member

Nope. We're invoking NuGet and NuGet is failing. Not much we can do I think

@Pospelove
Copy link
Contributor Author

Anyway thanks for taking a look, let's keep this issue open for now

@LilyWangLL LilyWangLL assigned Adela0814 and unassigned JackBoosY Dec 6, 2022
@SchaichAlonso
Copy link
Contributor

You need to setup an api key explicitly by running something like

  nuget setapikey "${{ secrets.GITHUB_TOKEN }}" -source "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json"

The example provided in the documentation on nuget binary caching has already been updated.

Pospelove added a commit to Pospelove/vcpkg-nuget-issue that referenced this issue Aug 17, 2023
@Pospelove
Copy link
Contributor Author

You need to setup an api key explicitly by running something like

  nuget setapikey "${{ secrets.GITHUB_TOKEN }}" -source "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json"

The example provided in the documentation on nuget binary caching has already been updated.

Thank you for your tip. I'm not working on binary caching in any of my projects atm, so I'll close this issue. I'll reopen this in case of being able to reproduce the original bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

No branches or pull requests

10 participants