Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wxwidgets] Fix usage, add cmake options #17111

Closed
wants to merge 39 commits into from

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 6, 2021

This PR will:

  • Automatically call wx-config and parse out cxxflags in vcpkg-cmake-wrapper.
  • Export all targets.
  • Fix the ouput path by running wx-config --libs.

Fixes #17072.

Upstream PR: wxWidgets/wxWidgets#2391

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 6, 2021
@JackBoosY
Copy link
Contributor Author

@SamuelMarks Can you please test this PR?

Thanks.

@JackBoosY JackBoosY requested a review from PhoebeHui April 6, 2021 09:49
@SamuelMarks
Copy link
Contributor

CMakeLists.txt

cmake_minimum_required(VERSION 3.0)
cmake_policy(SET CMP0048 NEW)
project(pp VERSION 0.0.1 LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 14)


file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/button.cpp src/main.cpp
     EXPECTED_HASH SHA256=c94699427f8b4a90c7ae3e075210bc44ae80098b5303a564f11d3991c620328f)
file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/widgets.h src/widgets.h
     EXPECTED_HASH SHA256=6ccef93318db87830fd400a8d217f08030358b0494bc594bf533bcf75da9cf2d)
file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/WX_3_0_BRANCH/samples/widgets/icons/button.xpm src/icons/button.xpm
     EXPECTED_HASH SHA256=c7f7bf9a4b678376a20af95adc213a467450a71040710dacc168fa6885a1ad0f)

set(src ${CMAKE_CURRENT_BINARY_DIR}/src/main.cpp)
find_package(wxWidgets REQUIRED)
add_executable(${PROJECT_NAME} ${src})
target_include_directories(${PROJECT_NAME} PRIVATE ${wxWidgets_INCLUDE_DIRS})
target_link_libraries(${PROJECT_NAME} PRIVATE ${wxWidgets_LIBRARIES})
target_compile_options(${PROJECT_NAME} PRIVATE ${wxWidgets_FLAGS})

sh

$ cd /tmp/vcpkg
$ gh pr checkout 17111
$ ./bootstrap-vcpkg.sh
$ cd /tmp/wx
$ rm -rf build && mkdir $_ && cd $_
/tmp/wx/build $ cmake -DCMAKE_TOOLCHAIN_FILE='/tmp/vcpkg/scripts/buildsystems/vcpkg.cmake' ..
-- The CXX compiler identification is AppleClang 12.0.0.12000032
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found wxWidgets: -L/tmp/vcpkg/packages/wxwidgets_x64-osx/lib;-pthread;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_xrc-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_qa-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_net-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_html-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_core-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_xml-3.1.a;/tmp/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu-3.1.a;-lwx_osx_cocoau_core-3.1;libjpeg.a;libpng.a>;libpng16d.a>;libz.a;libtiff.a>;libtiffd.a>;liblzma.a>;liblzmad.a>;libjpeg.a;libz.a;m;-framework AudioToolbox;-framework WebKit;-lwx_baseu-3.1;libexpat.a>;libexpat.a>;libz.a;-lwxregexu-3.1;libiconv.tbd;-framework CoreFoundation;-framework Security;-framework Carbon;-framework Cocoa;-framework IOKit (found version "3.1.4") 
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Found JPEG: /tmp/vcpkg/installed/x64-osx/debug/lib/libjpeg.a (found version "62") 
-- Found ZLIB: /tmp/vcpkg/installed/x64-osx/debug/lib/libz.a (found version "1.2.11") 
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/wx/build
/tmp/wx/build $ cmake --build .
[ 50%] Building CXX object CMakeFiles/pp.dir/src/main.cpp.o
[100%] Linking CXX executable pp
ld: library not found for -ljpeg
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [pp] Error 1
make[1]: *** [CMakeFiles/pp.dir/all] Error 2
make: *** [all] Error 2

Which is odd because:

JPEG: /tmp/vcpkg/installed/x64-osx/debug/lib/libjpeg.a (found version "62") 

@JackBoosY
Copy link
Contributor Author

@SamuelMarks Sorry I can't repro your issue on my machine, and I got some other errors:

-- The C compiler identification is AppleClang 12.0.0.12000032
-- The CXX compiler identification is AppleClang 12.0.0.12000032
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found wxWidgets: -L/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib;-pthread;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_xrc-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_qa-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_net-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_html-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_core-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_xml-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu-3.1.a;-lwx_osx_cocoau_core-3.1;libjpeg.a;libpng.a>;libpng16d.a>;libz.a;libtiff.a>;libtiffd.a>;liblzma.a>;liblzmad.a>;libjpeg.a;libz.a;m;-framework AudioToolbox;-framework WebKit;-lwx_baseu-3.1;libexpat.a>;libexpat.a>;libz.a;-lwxregexu-3.1;libiconv.tbd;-framework CoreFoundation;-framework Security;-framework Carbon;-framework Cocoa;-framework IOKit (found version "3.1.4")
-- Found JPEG: /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/debug/lib/libjpeg.a (found version "62")
-- Found ZLIB: /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/debug/lib/libz.a (found version "1.2.11")
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/vcpkg/Documents/vcpkg/test
Scanning dependencies of target test
[ 50%] Building CXX object CMakeFiles/test.dir/src/main.cpp.o
/Users/vcpkg/Documents/vcpkg/test/src/main.cpp:43:10: fatal error: 'wx/widgets.h' file not found
#include "wx/widgets.h"
         ^~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/test.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/test.dir/all] Error 2
make: *** [all] Error 2

Both wx/widgets.h and icons/button.xpm are not found.

@SamuelMarks
Copy link
Contributor

@JackBoosY You might need to remove your build dir and recreate it. Or you can manually do those lines:

$ cd build
$ mkdir -p 'src/icons'
$ curl -L 'https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/button.cpp' -o 'src/main.cpp'
$ curl -L 'https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/widgets.h' -o 'src/widgets.h'
$ curl -L 'https://raw.githubusercontent.com/wxWidgets/wxWidgets/WX_3_0_BRANCH/samples/widgets/icons/button.xpm' -o 'src/icons/button.xpm'

@JackBoosY
Copy link
Contributor Author

 /Library/Developer/CommandLineTools/usr/bin/c++   -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/test.dir/src/main.cpp.o  -o test  -L/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib -pthread /Users/vcpkg/Docu    ments/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_xrc-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_qa-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_net-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64    -osx/lib/libwx_osx_cocoau_html-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_core-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_xml-3.1.a /Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu-3.1.a -lwx_osx_c    ocoau_core-3.1 -ljpeg -llibpng.a> -llibpng16d.a> -lz -llibtiff.a> -llibtiffd.a> -lliblzma.a> -lliblzmad.a> -ljpeg -lz -lm -framework AudioToolbox -framework WebKit -lwx_baseu-3.1 -llibexpat.a> -llibexpat.a> -lz -lwxregexu-3.1 -llibiconv.tbd -framework CoreFoundation -framework Security -framework Carbon -framewo    rk Cocoa -framework IOKit /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/lib/libtiff.a -lpng /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/debug/lib/libexpat.a /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/debug/lib/libz.a -ljpeg -llibpng.a> -llibpng16d.a> -llibtiff.a> -llibtiffd.a> -lliblzma    .a> -lliblzmad.a> -framework AudioToolbox -framework WebKit -lwx_baseu-3.1 -lwxregexu-3.1 -llibiconv.tbd -framework CoreFoundation -framework Security -framework Carbon -framework Cocoa -framework IOKit -lpng -lm /Users/vcpkg/Documents/vcpkg/vcpkg/installed/x64-osx/debug/lib/liblzmad.a /Users/vcpkg/Documents/vcp    kg/vcpkg/installed/x64-osx/debug/lib/libjpeg.a

@JackBoosY
Copy link
Contributor Author

@SamuelMarks I think this is a bug of FindwxWidgets.cmake, when I call find_package(wxWidgets REQUIRED), I got the value of wxWidgets_LIBRARIES is:

-L/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib;-pthread;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_xrc-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_qa-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_net-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_html-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_osx_cocoau_core-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu_xml-3.1.a;/Users/vcpkg/Documents/vcpkg/vcpkg/packages/wxwidgets_x64-osx/lib/libwx_baseu-3.1.a;-lwx_osx_cocoau_core-3.1;libjpeg.a;libpng.a>;libpng16d.a>;libz.a;libtiff.a>;libtiffd.a>;liblzma.a>;liblzmad.a>;libjpeg.a;libz.a;m;-framework AudioToolbox;-framework WebKit;-lwx_baseu-3.1;libexpat.a>;libexpat.a>;libz.a;-lwxregexu-3.1;libiconv.tbd;-framework CoreFoundation;-framework Security;-framework Carbon;-framework Cocoa;-framework IOKit

You can find a lot of useless > appeared.

@SamuelMarks
Copy link
Contributor

@JackBoosY Yeah I've been hacking together this, it really is the wrong list of libraries, I could autoprepend them all but I've decided to go manually:

cmake_minimum_required(VERSION 3.3)
cmake_policy(SET CMP0048 NEW)
cmake_policy(SET CMP0060 NEW)
project(pp VERSION 0.0.0 LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 14)


file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/button.cpp src/main.cpp
     EXPECTED_HASH SHA256=c94699427f8b4a90c7ae3e075210bc44ae80098b5303a564f11d3991c620328f)
file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/c034a78/samples/widgets/widgets.h src/widgets.h
     EXPECTED_HASH SHA256=6ccef93318db87830fd400a8d217f08030358b0494bc594bf533bcf75da9cf2d)
file(DOWNLOAD https://raw.githubusercontent.com/wxWidgets/wxWidgets/WX_3_0_BRANCH/samples/widgets/icons/button.xpm src/icons/button.xpm
     EXPECTED_HASH SHA256=c7f7bf9a4b678376a20af95adc213a467450a71040710dacc168fa6885a1ad0f)

set(src ${CMAKE_CURRENT_BINARY_DIR}/src/main.cpp)

#add_library(libjpeg UNKNOWN IMPORTED)
#set_property(TARGET libjpeg PROPERTY IMPORTED_LOCATION "${JPEG_LIBRARIES}")


find_package(wxWidgets REQUIRED)
include(FindJPEG)
find_package(jpeg REQUIRED)

include(FindPNG)
find_package(png REQUIRED)
add_definitions(${PNG_DEFINITIONS})
string(REPLACE "optimized;" ""  PNG_LIBRARIES "${PNG_LIBRARIES}")
string(REPLACE "debug;" ""  PNG_LIBRARIES "${PNG_LIBRARIES}")

include(FindTIFF)
find_package(tiff REQUIRED)
string(REPLACE "optimized;" ""  TIFF_LIBRARIES "${TIFF_LIBRARIES}")
string(REPLACE "debug;" ""  TIFF_LIBRARIES "${TIFF_LIBRARIES}")

include(FindLibLZMA)
find_package(lzma REQUIRED)

message(LIBLZMA_LIBRARIES = "${LIBLZMA_LIBRARIES}")

string(REPLACE ">" ""  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")
string(REPLACE ";libjpeg.a;" ";${JPEG_LIBRARIES};"  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")
string(REPLACE ";libz.a" ""  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")
string(REPLACE ";libpng16d.a" ""  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")
string(REPLACE ";libpng.a;" ";${PNG_LIBRARIES};"  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")
string(REPLACE ";libtiff.a;libtiffd.a;" ";${TIFF_LIBRARIES};"  wxWidgets_LIBRARIES "${wxWidgets_LIBRARIES}")

add_executable(${PROJECT_NAME} "${src}")
target_include_directories(${PROJECT_NAME} PRIVATE "${wxWidgets_INCLUDE_DIRS}")
target_link_libraries(${PROJECT_NAME} PRIVATE "${wxWidgets_LIBRARIES}")
target_compile_options(${PROJECT_NAME} PRIVATE "${wxWidgets_FLAGS}")

This is really an awful hack… even if at some point I am able to get it to build and run properly. What's the proper way of depending on wxWidgets with vcpkg on macOS?

@JackBoosY
Copy link
Contributor Author

@SamuelMarks There are two ways to solve it:

  1. waiting for cmake to fix FindWxwidgets.cmake.
  2. export unofficial target wxwidgets to avoid this.

@PhoebeHui PhoebeHui marked this pull request as draft May 26, 2021 07:45
@SamuelMarks
Copy link
Contributor

So what should I expect, shall I keep waiting for a fix here, should I try and contribute to CMake directly, or…?

@JackBoosY JackBoosY added the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 9, 2021
@SamuelMarks
Copy link
Contributor

FYI: Looks like some unrelated things were merged in…

@JackBoosY
Copy link
Contributor Author

@SamuelMarks Becuase this PR will fix 3 issues.

@talregev
Copy link
Contributor

talregev commented Aug 20, 2021

@Be-ing I will continue my job after your PR #19274 merged.

Hi @JackBoosY,
#19274 PR merge to the master.
Can you merge master to here to include this changes?
Can you continue to work on this port?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout ab60f27567ec24ab97289fb7a1d8455c74bcad04 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 1331fab..ffecb60 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6782,7 +6782,7 @@
     },
     "wxwidgets": {
       "baseline": "3.1.5",
-      "port-version": 3
+      "port-version": 4
     },
     "x-plane": {
       "baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index f2ade9a..d686454 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "e8dec57de7c4d7c31f123d67a38631b713c5dee4",
+      "git-tree": "07c83fd019148ae37ade69fe8c0446aa6bf1dbaa",
       "version-semver": "3.1.5",
       "port-version": 4
     },

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 20, 2021
@BillyONeal
Copy link
Member

I just tested this change and confirm that it fixes plplot[wxwidgets].

@JackBoosY
Copy link
Contributor Author

I just tested this change and confirm that it fixes plplot[wxwidgets].

Yeah, but the upstream has absolutely no intention to approve to my changes.

@talregev
Copy link
Contributor

@JackBoosY Please link again your fix PRs on wxwidgets

@JackBoosY
Copy link
Contributor Author

@JackBoosY Please link again your fix PRs on wxwidgets

Added to my first comment.

@FrankXie05
Copy link
Contributor

@JackBoosY Can you resolve your conflict to make sure it works?

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Jan 21, 2022
@JackBoosY
Copy link
Contributor Author

This PR needs the upstream approval.

@talregev
Copy link
Contributor

@JackBoosY Hi, please don't merge this PR, Just fix it until we get the approval.

@playgithub
Copy link
Contributor

Blocked in upstream (wxWidgets/wxWidgets#2391) for quite a long time, why not use a patch in vcpkg instead?

@JackBoosY
Copy link
Contributor Author

@playgithub Because I can't vouch for correctness.

@talregev
Copy link
Contributor

@playgithub Because I can't vouch for correctness.

@JackBoosY You have tests to vouch the correctness.
Also We can check.

@talregev
Copy link
Contributor

talregev commented Mar 25, 2022

@JackBoosY wxwidgets don't compile on linux:
Please fix it on another PR.

tal@tal-pav15:~/vcpkg$ ./vcpkg install wxwidgets
Computing installation plan...
The following packages will be built and installed:
    wxwidgets[core]:x64-linux -> 3.1.5#7
Detecting compiler hash for triplet x64-linux...
Restored 0 packages from /home/tal/.cache/vcpkg/archives in 10.06 ms. Use --debug to see more details.
Starting package 1/1: wxwidgets:x64-linux
Building package wxwidgets[core]:x64-linux...
-- Using cached wxWidgets-wxWidgets-9c0a8be1dc32063d91ed1901fd5fcd54f4f955a1.tar.gz.
-- Extracting source /home/tal/vcpkg/downloads/wxWidgets-wxWidgets-9c0a8be1dc32063d91ed1901fd5fcd54f4f955a1.tar.gz
-- Applying patch disable-platform-lib-dir.patch
-- Applying patch fix-build.patch
-- Using source at /home/tal/vcpkg/buildtrees/wxwidgets/src/54f4f955a1-0d7c66a59e.clean
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
    Command failed: /home/tal/vcpkg/downloads/tools/cmake-3.22.2-linux/cmake-3.22.2-linux-x86_64/bin/cmake /home/tal/vcpkg/buildtrees/wxwidgets/src/54f4f955a1-0d7c66a59e.clean -DwxUSE_REGEX=builtin -DwxUSE_ZLIB=sys -DwxUSE_EXPAT=sys -DwxUSE_LIBJPEG=sys -DwxUSE_LIBPNG=sys -DwxUSE_LIBTIFF=sys -DwxBUILD_DISABLE_PLATFORM_LIB_DIR=ON -DwxUSE_STL=OFF -DwxUSE_STD_CONTAINERS=OFF -DCMAKE_MAKE_PROGRAM=/home/tal/vcpkg/downloads/tools/ninja-1.10.2-linux/ninja -DCMAKE_SYSTEM_NAME=Linux -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/home/tal/vcpkg/scripts/toolchains/linux.cmake -DVCPKG_TARGET_TRIPLET=x64-linux -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/home/tal/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/home/tal/vcpkg -D_VCPKG_INSTALLED_DIR=/home/tal/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/home/tal/vcpkg/packages/wxwidgets_x64-linux/debug
    Working Directory: /home/tal/vcpkg/buildtrees/wxwidgets/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/tal/vcpkg/buildtrees/wxwidgets/config-x64-linux-dbg-out.log
      /home/tal/vcpkg/buildtrees/wxwidgets/config-x64-linux-dbg-err.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:393 (vcpkg_execute_required_process)
  ports/wxwidgets/portfile.cmake:35 (vcpkg_cmake_configure)
  scripts/ports.cmake:145 (include)

@dg0yt
Copy link
Contributor

dg0yt commented Mar 25, 2022

Since April 6, 2021, problems with the debug variant and pc files were resolved for some dependencies.

IMHO this PR should be moved forward:

  • Add x64-linux failure to the CI baseline. Reason: no GTK3 in CI.
  • Add a CI test port which builds an executable which links to wxwidgets (or depends on other ports' features which would do that).
  • Verify that this executable properly links in the debug variant.

Unfortunately it is hard to contribute here without x64-linux support.

@playgithub
Copy link
Contributor

Let it work please, thanks.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 13, 2022

Let it work please, thanks.

Please test #24047.

@playgithub
Copy link
Contributor

@dg0yt

Please test #24047.

I'd like to test it, but I'll test conan first 😅
Thanks all the same.

@JackBoosY
Copy link
Contributor Author

In favor of #24047.

@JackBoosY JackBoosY closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet