-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wxwidgets] build failure on linux #23758
Comments
@talregev I think you know that there were previous issues. vcpkg tool even prints the link: |
Like I say, I try to talk with @JackBoosY many times and we didn't solve this issue. There is a long time we cannot compile wxwidgets on linux. for a few years now. This is seems logic to you? |
It is okay to express that you are not satisified with the progress. But I'm not convinced that opening another issue helps. The key issue with wxwidgets on Linux in vcpkg now is that vcpkg doesn't have gtk3. So no CI. At least until #22201 is merged. |
There is also a PR #17111, but they holding it for nothing.
The issue is not gtk. If you go to the PR #17111 , it already solve without the new gtk. |
(In addition, if you go to the PR #17111, you will see that my comments about correctly dealing with the debug variant are not resolved.) |
I didn't expect to solve all the problems, but at least let break the problems and deal with them one of the time. |
Very sorry for long time no response, because I'm quite busy in those days.
I remember I fixed this issue before, can anyone metion me about this part? |
It is not my decision. But I'm not too optimistic about PRs that cannot be tested in CI. |
Can you make a PR to solve only this problem? |
@talregev Yeah, but I forgot how I fixed this issue, let me view my commits. |
Thank you. |
The Cotire stuff should be disabled IIRC. There were multiple wxwidgets PRs from @JackBoosY at some point. |
Maybe this will help? |
Agreed, upstream wxwidgets should deprecate Cotire in their cmake build system, which is not suitable for modernizing cmake exports. |
@JackBoosY @dg0yt Can you help them to do that? They ask for help. They ask for assistance of cmake experts. |
I don't think it's related to this issue. |
ok. Can you try something you think it will work? I can also test it on my machine. |
That's a big work since Wxwidgets's buildsystem is huge, I don't think I have much time to make some help in this part.
I can repro this issue locally, so let me fix it. |
Related fix: wxWidgets/wxWidgets@2f6dd5e |
Can you make a PR with a patches for all the fixes that you make for wxwidgets? |
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg install wxwidgets
Failure logs
-Cut and paste the appropriate build messages from the console output.
-Please attach any additional failure logs mentioned in the console output.
wxwidgets.zip
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.
I try to talk with @JackBoosY many times to solve this issue.
The text was updated successfully, but these errors were encountered: