Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bzip2] Fix installation when VCPKG_BUILD_TYPE is set #12772

Closed
wants to merge 1 commit into from

Conversation

AenBleidd
Copy link
Contributor

Commit 458c20e added vcpkg_fixup_pkgconfig()
that breaks installation when VCPKG_BUILD_TYPE is set:

-- CHECK_LIB_bz2d_DEBUG:CHECK_LIB_bz2d_DEBUG-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:239 (message):
  Library "bz2d" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:348 (vcpkg_fixup_pkgconfig_check_files)
  ports/bzip2/portfile.cmake:51 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Signed-off-by: Vitalii Koshura [email protected]

Commit 458c20e added vcpkg_fixup_pkgconfig()
that breaks installation when VCPKG_BUILD_TYPE is set:

```
-- CHECK_LIB_bz2d_DEBUG:CHECK_LIB_bz2d_DEBUG-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:239 (message):
  Library "bz2d" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:348 (vcpkg_fixup_pkgconfig_check_files)
  ports/bzip2/portfile.cmake:51 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)
```

Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd
Copy link
Contributor Author

Closing as a duplicate of #12759

@AenBleidd AenBleidd closed this Aug 6, 2020
@AenBleidd AenBleidd deleted the vko_fix_bzip2 branch August 6, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant