[bzip2] fixes for building release-only

[cenit]

Restore the possibility to build bzip2 with a release-only triplet.
I'd also suggest to move one of the CI pipelines to test ports for this configuration, which is very common in production.
Closes #12799

[cenit]

EOL is now LF only, sorry for the very noisy diff. Luckily GitHub has an option in the diff view to hide whitespace-only changes

[LilyWangL]

The error on CI baseline will be fixed in PR #12766.

[Neumann-A]

@cenit: please stop mixing port fixes with smaller script fixes. Your are invalidating all the cached archives which use vcpkg_fixup_pkgconfig() and don't depend on bzip2. Although you might not see the benefit of message(STATUS "Checking file: ${_file}") since you probably only dealt with ports installing only a few *.pc files it is quite important to know where the error occurred if you have to deal with a port installing 20+ *.pc files

[cenit]

That's a problem for port creators, not port users. For the same reasons there is no output for vcpkg_fixup_cmake_targets or many others.
We should assume that when you install the port, it should just work, and output should be minimal as it always has been

[c72578]

We should assume that when you install the port, it should just work

This PR here already shows the opposite of such an assumption

[cenit]

This PR here already shows the opposite of such an assumption

again, that's not a reason to fill up user screen with unnecessary debug information.
Such problems should be detected during review and from CI

[Neumann-A]

@cenit with that logic vcpkg should not output anything. The messages are meant as progress messages not debug info. If you would rather like to see 'fixing pkgconfig x of y' I can make that change. I would also like to see some progress messages for fixup_cmake because ports like qt and vtk take a long time to fixup due to the amount of small file io.

[cenit]

with that logic vcpkg should not output anything

tbh I'd love it :)
Output only in case of errors, otherwise just a sequence of
"Starting package 1/97"
"Finishing package 1/97"
....
"Starting package 97/97"
"Finishing package 97/97"
such a lovely output 😄

[AenBleidd]

Maybe just a global verbosity flag should be added for vcpkg? Then every port user can control amount of information they'd wish to see...

[cenit]

on files (with a fixed standardized syntax) of course you can write as much as you want!

[AenBleidd]

@LilyWangL, any news here? All CI fails looks like not really related to this particular PR...

[past-due]

I've also hit this issue, and am eager to see this fix merged.

[LilyWangL]

The CI fails is not related with this PR, it will be fixed by PR #12856.

[gitcop-devel]

@cenit, please follow common git commit practices:

Make only one change per commit and avoid including unrelated changes

The changes to the file scripts/cmake/vcpkg_fixup_pkgconfig.cmake are unrelated to "[bzip2] fixes for building release-only" (commit a3e2935)

[AenBleidd]

@gitcop-devel, this repo contains examples that contradict this rule ;)