Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-baseline][manyport] Fix baseline error #11742

Merged
merged 8 commits into from
Jun 4, 2020
Merged

[vcpkg-baseline][manyport] Fix baseline error #11742

merged 8 commits into from
Jun 4, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 3, 2020 •
edited
Loading

  • fastrtps: update hash
  • cpp-taskflow: update hash
  • eabase: retrigger test to refresh baseline status
  • sdformat9: fix find dependency

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 3, 2020
@JackBoosY JackBoosY changed the title [vcpkg-baseline][fastrtps] Fix source hash [vcpkg-baseline][manyport] Fix baseline error Jun 3, 2020
@cenit
Copy link
Contributor

cenit commented Jun 3, 2020

unfortunately #11502 is still full of regressions. Thanks for working on them, let's hope to get out of this problem soon

BillyONeal
BillyONeal approved these changes Jun 3, 2020
View reviewed changes
ports/cpp-taskflow/portfile.cmake Outdated Show resolved Hide resolved
ports/fastrtps/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

#11759 'fixes' the gmp regression on osx.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jun 4, 2020 •
edited
Loading

  • sdformat9:x64-osx
  • ignition-msgs5:x64-osx
  • nettle:x64-osx
  • gmp:x64-osx
  • tinyxml:x86-windows
  • argtable2:x86-windows
  • gsoap:x86-windows
  • mpir:x64-windows
  • gmp:x64-windows-static

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY marked this pull request as ready for review June 4, 2020 02:34
This was referenced Jun 4, 2020
Merged
Merged
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 mentioned this pull request Jun 4, 2020
Merged
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 4, 2020
@PhoebeHui
Copy link
Contributor

@dan-shaw, @BillyONeal, could you help review and merge this PR?

@JackBoosY JackBoosY mentioned this pull request Jun 4, 2020
Merged
This was referenced Jun 4, 2020
Merged
Merged
@dan-shaw dan-shaw merged commit a59ddd9 into microsoft:master Jun 4, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jun 4, 2020

@JackBoosY thanks for working on this

@JackBoosY JackBoosY deleted the dev/jack/fix_fastrtps_20200603 branch June 5, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackBoosY @cenit @BillyONeal @PhoebeHui @dan-shaw