Configuring overlay ports and overlay triplets through the manifest

[valeriaconde]

Docs PR: microsoft/vcpkg#27172

[valeriaconde]

@microsoft-github-policy-service agree [company="microsoft"]

[valeriaconde]

@microsoft-github-policy-service agree company="microsoft"

[autoantwort]

Currently relative paths are relative to the CWD and not to the manifest root. And I guess e2e test will come to test relative paths in manifest file and manifest root != CWD.

I really like this change 👍

[Neumann-A]

The only issue I have with adding this stuff into the manifest is that the manifest becomes kind of a configuration file for vcpkg instead of a clean dependency definition. Maybe vcpkg should add a new differentiation and add a vcpkg-project.json instead of calling everything vcpkg.json

[BillyONeal]

The only issue I have with adding this stuff into the manifest is that the manifest becomes kind of a configuration file for vcpkg instead of a clean dependency definition. Maybe vcpkg should add a new differentiation and add a vcpkg-project.json instead of calling everything vcpkg.json

That is, vcpkg-configuration.json, where the registries definitions already live. That makes sense to me...

[BillyONeal]

That is, vcpkg-configuration.json, where the registries definitions already live. That makes sense to me...

Wait, that's what this PR already does. @Neumann-A I think the "vcpkg.json is the durable/transitive declaration of dependencies" is unaffected here.

[Neumann-A]

Wait, that's what this PR already does. @Neumann-A I think the "vcpkg.json is the durable/transitive declaration of dependencies" is unaffected here.

Maybe the title of the PR should be changed? Or is vcpkg-configuration.json also considered to be the manifest?
Furthermore can i use the manifest overlays without defining a registry?

[valeriaconde]

We consider vcpkg-configuration.json as part of what composes "the manifest" , although this is not clear in the docs for sure.

Furthermore can i use the manifest overlays without defining a registry?

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

[Neumann-A]

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

Is this documented somewhere? I always thought you need to have two different files (vcpkg.json; vcpkg-configuration.json).
https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md doesn't mention that.
https://github.com/microsoft/vcpkg/blob/master/docs/users/registries.md also seems to not mention it.
https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json also doesn't have that if I read it correctly.

[vicroms]

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

Is this documented somewhere? I always thought you need to have two different files (vcpkg.json; vcpkg-configuration.json). https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md doesn't mention that. https://github.com/microsoft/vcpkg/blob/master/docs/users/registries.md also seems to not mention it. https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json also doesn't have that if I read it correctly.

That would be my fault, I don't think it is documented other than the comment I made on the PR #239.

[valeriaconde]

That would be my fault, I don't think it is documented other than the comment I made on the PR #239.

I added this to the docs PR I have open (currently on the description of this PR)

[BillyONeal]

Thanks!