-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed vcpkg configuration in manifest #239
Embed vcpkg configuration in manifest #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I understand that putting this under a $
makes it so you don't have to modify manifest parsing code, but it shouldn't be too much work - two lines changed, I think)
Co-authored-by: nicole mazzuca <[email protected]>
…croms/vcpkg-tool into embed-vcpkg-configuration-in-manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit nit nit nit
Co-authored-by: Billy O'Neal <[email protected]>
…croms/vcpkg-tool into embed-vcpkg-configuration-in-manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the 1PM meeting we resolved this as "no x-" and we'll warn about it.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Allows specifying vcpkg configuration in manifest files.
The configuration is passed via a
vcpkg-configuration
object in the manifest file.Having a
vcpkg-configuration
block invcpkg.json
while also having avcpkg-configuration.json
file is not allowed.As a drive-by
format-manifest
has been changed to allow the configuration blocks.Example: