Update ClientPipelineApi, HttpMessageApi abstraction #4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
live1206
changed the title
|
Corresponding changes in Azure Plugin: Azure/azure-sdk-for-net#46835 |
...Microsoft.Generator.CSharp.ClientModel/test/Providers/Abstractions/ClientPipelineApiTests.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/Abstractions/ClientPipelineApi.cs
Outdated
Show resolved
Hide resolved
live1206
commented
Oct 28, 2024
...enerator/Microsoft.Generator.CSharp.ClientModel/src/Providers/Abstractions/HttpMessageApi.cs
Outdated
Show resolved
Hide resolved
...enerator/Microsoft.Generator.CSharp.ClientModel/src/Providers/Abstractions/HttpMessageApi.cs
Outdated
Show resolved
Hide resolved
...-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/RestClientProvider.cs
Outdated
Show resolved
Hide resolved
live1206
changed the title
JoshLove-msft
approved these changes
Oct 31, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
- Remove unused `ClientPipelineApi.CreateMessage` - Add `HttpRequestOptionsApi` to `ClientPipelineApi.Send(Async)` - Replace `HttpMessageApi.ResponseClassifier` with `HttpMessageApi.ApplyResponseClassifier` - Make abstraction more generic This fix is needed for below issues of Azure plugin: Azure/azure-sdk-for-net#46899 Azure/azure-sdk-for-net#46900 Azure/azure-sdk-for-net#46901 Azure/azure-sdk-for-net#46902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientPipelineApi.CreateMessageHttpRequestOptionsApitoClientPipelineApi.Send(Async)HttpMessageApi.ResponseClassifierwithHttpMessageApi.ApplyResponseClassifierThis fix is needed for below issues of Azure plugin:
Azure/azure-sdk-for-net#46899
Azure/azure-sdk-for-net#46900
Azure/azure-sdk-for-net#46901
Azure/azure-sdk-for-net#46902