Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request header should be set instead of add #46899

Closed
live1206 opened this issue Oct 30, 2024 · 2 comments
Closed

request header should be set instead of add #46899

live1206 opened this issue Oct 30, 2024 · 2 comments
Assignees
@live1206
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation

Comments

@live1206
Copy link
Member

live1206 commented Oct 30, 2024 •
edited
Loading

request header should be set instead of add
@live1206 live1206 added the CodeGen Issues that relate to code generation label Oct 30, 2024
@live1206 live1206 self-assigned this Oct 30, 2024
This was referenced Oct 30, 2024
Merged
Merged
@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Oct 30, 2024
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this issue Oct 31, 2024
@live1206
Update ClientPipelineApi, HttpMessageApi abstraction (#4816)
fe8f3f1 
- Remove unused `ClientPipelineApi.CreateMessage`
- Add `HttpRequestOptionsApi` to `ClientPipelineApi.Send(Async)`
- Replace `HttpMessageApi.ResponseClassifier` with
`HttpMessageApi.ApplyResponseClassifier`
- Make abstraction more generic

This fix is needed for below issues of Azure plugin:
Azure/azure-sdk-for-net#46899
Azure/azure-sdk-for-net#46900
Azure/azure-sdk-for-net#46901
Azure/azure-sdk-for-net#46902
@live1206
Copy link
Member Author

live1206 commented Nov 5, 2024

The current behavior in Azure client is Add, will keep the behavior unchanged as Add.

@live1206 live1206 closed this as completed Nov 5, 2024
swatkatz pushed a commit to swatkatz/typespec that referenced this issue Nov 5, 2024
@live1206
Update ClientPipelineApi, HttpMessageApi abstraction (microsoft#4816)
84992c3 
- Remove unused `ClientPipelineApi.CreateMessage`
- Add `HttpRequestOptionsApi` to `ClientPipelineApi.Send(Async)`
- Replace `HttpMessageApi.ResponseClassifier` with
`HttpMessageApi.ApplyResponseClassifier`
- Make abstraction more generic

This fix is needed for below issues of Azure plugin:
Azure/azure-sdk-for-net#46899
Azure/azure-sdk-for-net#46900
Azure/azure-sdk-for-net#46901
Azure/azure-sdk-for-net#46902
@live1206
Copy link
Member Author

live1206 commented Nov 6, 2024

To be consistent with MGC, we decided to use SetValue for headers.

@live1206 live1206 reopened this Nov 6, 2024
@live1206 live1206 closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@live1206 live1206

Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsquire @live1206