-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
e80f8d1
to
e5499d2
Compare
Whoops, I accidentally pushed a commit to your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is spooky. Here are three PRs with failing tests:
- Testing: intentionally failing .ts.lint test apawast/tslint-microsoft-contrib#1: failing .ts.lint test; correctly reports the failure
- Testing: intentionally failing Mocha test (with cross-var) apawast/tslint-microsoft-contrib#2: failing Mocha test with the
cross-var
changes - Testing: intentionally failing Mocha test (without package changes) apawast/tslint-microsoft-contrib#3: failing Mocha test without any package changes
The .ts.lint test correctly fails, but neither build with failing Mocha tests picked up on it. That seems like a blocker (unless there was user error on my end?).
I reproduced those test failure locally and realized that the message that you changed isn't what it's testing for, it's testing for true or false. The message could be anything and it'll pass regardless. I changed the tests to say false instead of true and it failed locally immediately. I didn't want to have random failing builds in the pipeline setup so I didn't push but if you want I can reproduce it in a different branch or something. Also thanks for looking into this! |
Ha, user error on my end indeed. I'll take another look. Thanks! |
@apawast apawast#3 is correctly on failed unit tests after reverting changes to Also, in case it's useful, some feedback about Azure Pipelines itself:
I'm happy to send you / your team more detailed feedback here or via another channel if you'd like. |
b309dc0
to
b860aa0
Compare
@JoshuaKGoldberg The changes I made to For the issue about getting through several clicks, that is just how Github handles getting to the pipeline from the repo. We can't do anything about it, however, I have heard there is a project in the works to fix this. Any other feedback you have, you can email it to me at [email protected] and I will be happy to pass it on to the appropriate people! |
Yes, but tslint and tslint-microsoft-contrib don't use a commonly used test runner. From #655:
For this PR to be merged, there should be no
Awesome, thanks!
No, it's how you handle getting to the pipeline from the repo 😄. See this PR on CircleCI: budgielang/budgie#641. Clicking Details takes you directly to a well-formatted display of which tasks failed. Anyway, this is bikeshedding - the real sticking point here is the package.json changeset. |
Okay I see. I have no problems removing the changes from them if you're okay with no test reporting (at least the logs will be colorful and I'm sure that's what you're used to looking at them anyways). I don't really know much about that repo to pipelines process, I was just relaying what other PMs informed me. But I'll definitely look into it! |
161dffe
to
08d6a8f
Compare
@JoshuaKGoldberg I changed them to match your master. Everything look okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Node 6 build failures are unrelated. |
Thanks for setting this up @apawast! We'll try this out for a while and send you feedback as we come across it. |
Oh, just a heads up, I don't have permissions to add it as an app to this repository. You'll want to work with @HamletDRC for that, I believe. It might need an admin who's a member of the @microsoft organization. |
PR checklist
Overview of change:
Add support for CI using Azure Pipelines
Is there anything you'd like reviewers to focus on?
I have created a build pipeline for tslint-microsoft-contrib project here: https://dev.azure.com/ms/tslint-microsoft-contrib
Microsoft employees should all have access to this already. Currently it's building off of my fork of the project, however, you or Will Smythe can change it to point to your repo.
I had to add the reporter to publish the results:
However, I found a new solution so that the reporter will not affect developers working on this project.